You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/08 12:59:18 UTC
[GitHub] [iotdb] choubenson opened a new pull request #5186: [IOTDB-2682][IOTDB-2693]Query more data which has been deleted in compaction from 0.12.5
choubenson opened a new pull request #5186:
URL: https://github.com/apache/iotdb/pull/5186
Delete data during the compaction in 0.12.5, then break it, and recover it at 0.13 will query all the data that has been deleted during the compaction in 0.12.5.
Notice: There may still be a situation where the data deleted in the 0.12 merge is queried. After 0.12 merges and generates the target file, the process is to read the deletion of all the source files, then delete the mods files of the source files, and finally write deletions into the target mods file. Assuming that after deleting the mods files of the source files, it is interrupted before writing to the target mods file, at this time, the deleted data will still be queried in recovery at 0.13.
Therefore, it can only be said that this pr reduces the possibility of this bug happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5186: Remove reading merge.mods in inner compaction recover
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5186:
URL: https://github.com/apache/iotdb/pull/5186#issuecomment-1061829695
[](https://coveralls.io/builds/47193680)
Coverage increased (+0.04%) to 67.884% when pulling **6f8792dd595c137dc4da59f98b276b9fa61cf0da on choubenson:deleteCompactionRecover** into **1584871a7cdca3b055f90ee43ffeb355eb8d8db3 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5186: [IOTDB-2682][IOTDB-2693]Query more data which has been deleted in compaction from 0.12.5
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5186:
URL: https://github.com/apache/iotdb/pull/5186#issuecomment-1061829695
[](https://coveralls.io/builds/47167762)
Coverage increased (+0.001%) to 67.846% when pulling **09f53a6dfa48a98e3c394a38962e6b8a2418e1af on choubenson:deleteCompactionRecover** into **1584871a7cdca3b055f90ee43ffeb355eb8d8db3 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5186: [IOTDB-2712]Remove reading merge.mods in inner compaction recover
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #5186:
URL: https://github.com/apache/iotdb/pull/5186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org