You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/03/18 00:40:37 UTC

Review Request 44998: Fixed m4 macro to enable strict C++11 conformance.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44998/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4963
    https://issues.apache.org/jira/browse/MESOS-4963


Repository: mesos


Description
-------

If the compiler supports C++11 or greater by default, we might
still need to specify "-std=c++11" to disable compiler support for
GNU-specific extensions or C++14. This is the case for GCC 6, which
defaults to "-std=g++14".


Diffs
-----

  m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION 

Diff: https://reviews.apache.org/r/44998/diff/


Testing
-------

make check


Thanks,

Neil Conway


Re: Review Request 44998: Fixed m4 macro to enable strict C++11 conformance.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44998/#review124133
-----------------------------------------------------------


Ship it!




Ship It!

- Joris Van Remoortere


On March 17, 2016, 11:40 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44998/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 11:40 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4963
>     https://issues.apache.org/jira/browse/MESOS-4963
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the compiler supports C++11 or greater by default, we might
> still need to specify "-std=c++11" to disable compiler support for
> GNU-specific extensions or C++14. This is the case for GCC 6, which
> defaults to "-std=g++14".
> 
> 
> Diffs
> -----
> 
>   m4/ax_cxx_compile_stdcxx.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44998/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>