[jira] [Comment Edited] (GEODE-5780) replace the geode LoggingThreadGroup by using Thread.setUncaughtExceptionHandler

["Darrel Schneider (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643671#comment-16643671 ] 

Darrel Schneider edited comment on GEODE-5780 at 10/9/18 4:27 PM:
------------------------------------------------------------------

A problem was found with one of the log messages in this fix.

It has the old \{0}, \{1} and needs to be changed to just have empty curly braces that log4j uses.

The message that had this mistake is one that is hardly ever logged (it had to be a NoClassDefFoundError unhandled by the JVM shutdown hook thread).

 


was (Author: dschneider):
A problem was found with one of the log messages in this fix.

It has the old \{0}, \{1} and needs to be changed to just have empty curly braces

 

> replace the geode LoggingThreadGroup by using Thread.setUncaughtExceptionHandler
> --------------------------------------------------------------------------------
>
>                 Key: GEODE-5780
>                 URL: https://issues.apache.org/jira/browse/GEODE-5780
>             Project: Geode
>          Issue Type: Improvement
>          Components: core
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.8.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> A long time ago geode wanted to make sure that any uncaught exceptions would be logged. This was before java 1.5 so the way we decided to do this was create thread groups for all the thread pools geode had. Each of these groups define an uncaught exception handler that would use the geode logger to log the exception.
> Since java 1.5 Thread now has setUncaughtExceptionHandler(UncaughtExceptionHandler).
> This would be simpler than creating a ThreadGroup. The geode LoggingThreadGroup actually keeps a static collection of all the groups created and it would be nice to get rid of that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)