You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/21 03:37:19 UTC
[GitHub] [skywalking] arugal opened a new pull request #7975: support search browser service
arugal opened a new pull request #7975:
URL: https://github.com/apache/skywalking/pull/7975
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
##### searchBrowserService
##### searchBrowserServices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal commented on a change in pull request #7975: support search browser service
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #7975:
URL: https://github.com/apache/skywalking/pull/7975#discussion_r733375118
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetadataQueryDAO.java
##########
@@ -44,16 +45,18 @@
List<Database> getAllDatabases() throws IOException;
/**
- * @param keyword to filter the normal service
+ * @param nodeType describe which kind of node of Service
+ * @param keyword to filter the normal service
* @return the list of normal services matching the given keyword
*/
- List<Service> searchServices(final String keyword) throws IOException;
+ List<Service> searchServices(final NodeType nodeType, final String keyword) throws IOException;
/**
+ * @param nodeType describe which kind of node of Service
* @param serviceCode to literal match
* @return the service matching the given full name.
*/
- Service searchService(final String serviceCode) throws IOException;
+ Service searchService(final NodeType nodeType, final String serviceCode) throws IOException;
Review comment:
Also need to add browser-related commands to swctl https://github.com/apache/skywalking/issues/7905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] arugal merged pull request #7975: support search browser service
Posted by GitBox <gi...@apache.org>.
arugal merged pull request #7975:
URL: https://github.com/apache/skywalking/pull/7975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7975: support search browser service
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7975:
URL: https://github.com/apache/skywalking/pull/7975#discussion_r733353167
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetadataQueryDAO.java
##########
@@ -44,16 +45,18 @@
List<Database> getAllDatabases() throws IOException;
/**
- * @param keyword to filter the normal service
+ * @param nodeType describe which kind of node of Service
+ * @param keyword to filter the normal service
* @return the list of normal services matching the given keyword
*/
- List<Service> searchServices(final String keyword) throws IOException;
+ List<Service> searchServices(final NodeType nodeType, final String keyword) throws IOException;
/**
+ * @param nodeType describe which kind of node of Service
* @param serviceCode to literal match
* @return the service matching the given full name.
*/
- Service searchService(final String serviceCode) throws IOException;
+ Service searchService(final NodeType nodeType, final String serviceCode) throws IOException;
Review comment:
FYI @LIU-WEI-git This PR will be merged soon and it breaks your implementation a little. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org