[GitHub] [spark] MaxGekk commented on a change in pull request #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#discussion_r386550812
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ##########
 @@ -559,7 +567,6 @@ case class JsonToStructs(
       (rows: Iterator[InternalRow]) => if (rows.hasNext) rows.next().getMap(0) else null
   }
 
-  val nameOfCorruptRecord = SQLConf.get.getConf(SQLConf.COLUMN_NAME_OF_CORRUPT_RECORD)
 
 Review comment:
   `nameOfCorruptRecord` is used only in `parser` below. I would try to move it there:
   ```scala
   @transient lazy val parser = {
     val parsedOptions = new JSONOptions(
       options,
       timeZoneId.get,
       SQLConf.get.getConf(SQLConf.COLUMN_NAME_OF_CORRUPT_RECORD))
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org