You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/19 19:45:58 UTC

[GitHub] [beam] apilloud commented on a change in pull request #14014: Add DDL support to SQL Transform

apilloud commented on a change in pull request #14014:
URL: https://github.com/apache/beam/pull/14014#discussion_r579431949



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/SqlTransform.java
##########
@@ -227,8 +253,14 @@ public SqlTransform withPositionalParameters(List<?> parameters) {
     return toBuilder().setQueryParameters(QueryParameters.ofPositional(parameters)).build();
   }
 
-  public SqlTransform withAutoUdfUdafLoad(boolean autoUdfUdafLoad) {
-    return toBuilder().setAutoUdfUdafLoad(autoUdfUdafLoad).build();
+  public SqlTransform withDdlString(String ddlString) {
+    List<String> ddlStrings = new ArrayList<>(ddlStrings());

Review comment:
       Please use `ImmutableList` here instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org