You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/01 04:01:57 UTC
[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request #4756: libc:machine:xtensa:add xtensa libc implement
zhuyanlinzyl opened a new pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756
## Summary
Add xtensa arch libc implement
## Impact
No.
## Testing
Testing pass on memcpy_test, memset_test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
zhuyanlinzyl commented on pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#issuecomment-958672674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
zhuyanlinzyl commented on pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#issuecomment-958672674
@Ouss4 Thansk. Please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#discussion_r741402050
##########
File path: libs/libc/machine/xtensa/arch_setjmp.S_bk
##########
@@ -0,0 +1,374 @@
+/****************************************************************************
+ * libs/libc/machine/xtensa/arch_setjmp.S
Review comment:
Looks like this files sneaked in with a `git add .`
(This looks like what was supposed to be a backup file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#issuecomment-957940986
@Ouss4 could you review the update again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#issuecomment-957940986
@Ouss4 could you review the update again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
zhuyanlinzyl commented on pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#issuecomment-958672674
@Ouss4 Thansk. Please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#issuecomment-957940986
@Ouss4 could you review the update again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#discussion_r741402050
##########
File path: libs/libc/machine/xtensa/arch_setjmp.S_bk
##########
@@ -0,0 +1,374 @@
+/****************************************************************************
+ * libs/libc/machine/xtensa/arch_setjmp.S
Review comment:
Looks like this files sneaked in with a `git add .`
(This looks like what was supposed to be a backup file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4756: libc:machine:xtensa:add xtensa libc implement
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4756:
URL: https://github.com/apache/incubator-nuttx/pull/4756#discussion_r740150888
##########
File path: libs/libc/machine/xtensa/arch_memcpy.S
##########
@@ -0,0 +1,281 @@
+/****************************************************************************
+ * libs/libc/machine/xtensa/arch_memcpy.S
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http:#www.apache.org/licenses/LICENSE-2.0
Review comment:
```suggestion
* http://www.apache.org/licenses/LICENSE-2.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org