You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/19 04:54:45 UTC
[GitHub] [flink] RocMarshal commented on a change in pull request #15755: [FLINK-22318][table] Support RENAME column name for ALTER TABLE state…
RocMarshal commented on a change in pull request #15755:
URL: https://github.com/apache/flink/pull/15755#discussion_r752861919
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java
##########
@@ -144,6 +149,116 @@ public static Operation convertChangeColumn(
// TODO: handle watermark and constraints
}
+ public static Operation convertRenameColumn(
+ ObjectIdentifier tableIdentifier,
+ String originColumnName,
+ String newColumnName,
+ CatalogTable catalogTable) {
+
+ Schema modifiedTableSchema = catalogTable.getUnresolvedSchema();
+ validateColumnName(originColumnName, newColumnName, modifiedTableSchema);
+
+ Schema.Builder builder = Schema.newBuilder();
+ // build column
+ modifiedTableSchema.getColumns().stream()
+ .forEach(
+ column -> {
+ if (StringUtils.equals(column.getName(), originColumnName)) {
+ buildNewColumnFromOriginColumn(builder, column, newColumnName);
+ } else {
+ buildNewColumnFromOriginColumn(builder, column, column.getName());
+ }
+ });
+ // build primary key column
+ List<String> originPrimaryKeyNames =
+ modifiedTableSchema
+ .getPrimaryKey()
+ .map(Schema.UnresolvedPrimaryKey::getColumnNames)
+ .orElseGet(Lists::newArrayList);
+
+ List<String> newPrimaryKeyNames =
+ originPrimaryKeyNames.stream()
+ .map(
+ pkName ->
+ StringUtils.equals(pkName, originColumnName)
+ ? newColumnName
+ : pkName)
+ .collect(Collectors.toList());
+
+ if (newPrimaryKeyNames.size() > 0) {
+ builder.primaryKey(newPrimaryKeyNames);
+ }
+ // build watermark
+ modifiedTableSchema.getWatermarkSpecs().stream()
+ .forEach(
+ watermarkSpec -> {
+ String watermarkRefColumnName = watermarkSpec.getColumnName();
+ Expression watermarkExpression = watermarkSpec.getWatermarkExpression();
+ if (StringUtils.equals(watermarkRefColumnName, originColumnName)) {
+ String newWatermarkExpression =
+ ((SqlCallExpression) watermarkExpression)
+ .getSqlExpression()
+ .replace(watermarkRefColumnName, newColumnName);
Review comment:
> In any case, we should start putting each operation execution in a separate class. Otherwise `OperationConverterUtils` or `OperationConverter` grow infinitely. `OperationConverter` can just be a registry for mapping the instance to a class. We can then make certain entities available e.g. schema resolver or catalog manager.
@twalthr @wuchong In my limited read, it would be better if we would do the refactor on the parts of OperationConverter after completing FLINK-21634. Please let me know what's your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org