You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/06/26 07:29:58 UTC
[GitHub] flink pull request #4181: Add E() support in Table API
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/4181
Add E() support in Table API
Adds E() to Table API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-6942
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4181
----
commit b84086f0e227a81b4f78669a4998c0b3be12125b
Author: twalthr <tw...@apache.org>
Date: 2017-06-26T07:28:59Z
Add E() support in Table API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4181: [FLINK-6942] [table] Add E() support in Table API
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4181
Thanks @twalthr .
+1 to merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4181: [FLINK-6942] [table] Add E() support in Table API
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4181: [FLINK-6942] [table] Add E() support in Table API
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/4181
I will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4181: [FLINK-6942] [table] Add E() support in Table API
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4181
Hi @twalthr Thanks a lot for open this PR. It looks great to me. Here only one suggestion is add documentation for tableAPI.
Best,
SunJincheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4181: [FLINK-6942] [table] Add E() support in Table API
Posted by ch33hau <gi...@git.apache.org>.
Github user ch33hau commented on a diff in the pull request:
https://github.com/apache/flink/pull/4181#discussion_r123957141
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala ---
@@ -924,6 +924,19 @@ object pi {
}
/**
+ * Returns a value that is closer than any other value to e.
+ */
+object e {
+
+ /**
+ * Returns a value that is closer than any other value to e.
--- End diff --
A trivial comment...
Scala Doc should be
```
/**
*
*
```
Instead of
```
/**
*
*
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4181: [FLINK-6942] [table] Add E() support in Table API
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/4181
Thanks for the notice. Actually I updated the docs, but might forgot to add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---