You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/02 11:02:02 UTC
[GitHub] [cloudstack] NuxRo opened a new pull request #4124: Missing python3 libvirt bindings
NuxRo opened a new pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124
Missing python3 libvirt bindings on CentOS7 effectively break security groups.
There are 0 firewall rules added. The agent logs report:
```2020-06-02 10:58:34,346 DEBUG [kvm.resource.LibvirtComputingResource] (main:null) (logid:) Traceback (most recent call last): File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 26, in <module> import libvirtModuleNotFoundError: No module named 'libvirt'
```
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637652650
> @weizhouapache yes. python36-libvirt.x86_64 is a valid package from EPEL. :/ there is no python3-libvirt although it sounds better :)
thanks @svenvogel
it seems epel repo is not suggested in installation guide, do we need to add it in cloudstack document ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638549285
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] svenvogel commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637610248
@weizhouapache yes. python36-libvirt.x86_64 is a valid package from EPEL. :/ there is no python3-libvirt although it sounds better :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638548647
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637607524
@NuxRo
I do not use centos7. I have two questions
(1) is python36-libvirt valid in official centos7 repo or epel repo?
(2) is python3-libvirt a valid package in centos7 ? if so, I suggest to use python3-libvirt instead of python36-libvirt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638548647
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638549285
Smoketests are not necessary as change is in the centos7 package. Can we get a +1 on this if someone can validate that, I tested in the `bhaisaab/centos7-cloudstack-slave` container the package was available in epel:
```
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo edited a comment on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
NuxRo edited a comment on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637563977
It'd be great if in such instances we'd get some sort of clue in the UI or somehow get an idea that SGs are not working, or fail adding the hypervisor altogether. It took me a while to catch the problem, idiotically assuming it works. Ended up with a stupid CentOS 5 VM IP spoofing the hell out of it. At least tc was doing its job, so the perpetrators only had 200 Mbps :-D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637481276
Not sure how this was not tested during 4.14 👎
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
NuxRo commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638069557
> > @weizhouapache yes. python36-libvirt.x86_64 is a valid package from EPEL. :/ there is no python3-libvirt although it sounds better :)
>
> thanks @svenvogel
> it seems epel repo is not suggested in installation guide, do we need to add it in cloudstack document ?
We should definitely do that, EPEL is pretty safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638053340
FWIW: just did an install of master on centos7;
```
Error: Package: cloudstack-common-4.15.0.0-SNAPSHOT.fc31.x86_64 (/cloudstack-common-4.15.0.0-SNAPSHOT.fc31.x86_64)
Requires: python(abi) = 3.7
Installed: python-2.7.5-77.el7_6.x86_64 (@updates)
python(abi) = 2.7
python(abi) = 2.7
Installed: python3-3.6.8-13.el7.x86_64 (@base)
python(abi) = 3.6
python(abi) = 3.6
Available: python-2.7.5-88.el7.x86_64 (base)
python(abi) = 2.7
python(abi) = 2.7
Available: python34-3.4.10-4.el7.x86_64 (epel)
python(abi) = 3.4
```
I don't know if it is significant, but it seems to ask for python 3.7. (not libvirt related management server install.
maybe due to build on fedora??? so probably nothing/red hering
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638549285
Smoketests are not necessary as change is in the centos7 package. I tested in the `bhaisaab/centos7-cloudstack-slave` container the package is available in epel:
```
Installing:
python36-libvirt x86_64 4.5.0-1.el7 epel 284 k
I
```
Doc change requested @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638344755
Me neither. Adding this to the docs will only confuse people. RPM and DEB packages should depend on everything you need to run CloudStack.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638325482
@NuxRo changing just the base branch is not enough, I've taken the liberty to fix it for you and do a force push. Now the PR can be merged for 4.14.1.0 and fwd merged to master.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638345083
ok, then let's leave it as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638553902
Doc PR raised https://github.com/apache/cloudstack-documentation/pull/135 cc @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638326324
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638341026
Packaging result: ✔centos7 ✔debian. JID-1272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637492562
@DaanHoogland The Security Grouping part has already moved to Python 3. The scripts inside the VR for example are still Py2.
security_group.py is a standalone script outside all the other scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
NuxRo commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637563977
It'd be great if in such instances we'd get some sort of clue in the UI or somehow get an idea that SGs are not working, or fail adding the hypervisor at all. It took me a while to catch the problem, idiotically assuming it works. Ended up with a stupid CentOS 5 VM IP spoofing the hell out of it. At least tc was doing it's job, so the perpetrators only had 200 Mbps :-D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637547983
@NuxRo can you rebase and edit the PR for 4.14?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
NuxRo commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638066581
Daan, it looks like those RPMs were built on Fedora 31 which probably comes with python 3.7.
The python version is not mentioned in the rpm spec file, but rpm is "smart" enough to add certain dependencies outside of what is in the spec file, this can be turned off in the spec with "AutoReqProv: no".
Ideally you should be building the RPMs in a CentOS7 environment, though...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638053340
FWIW: just did an install of master on centos7;
```
Error: Package: cloudstack-common-4.15.0.0-SNAPSHOT.fc31.x86_64 (/cloudstack-common-4.15.0.0-SNAPSHOT.fc31.x86_64)
Requires: python(abi) = 3.7
Installed: python-2.7.5-77.el7_6.x86_64 (@updates)
python(abi) = 2.7
python(abi) = 2.7
Installed: python3-3.6.8-13.el7.x86_64 (@base)
python(abi) = 3.6
python(abi) = 3.6
Available: python-2.7.5-88.el7.x86_64 (base)
python(abi) = 2.7
python(abi) = 2.7
Available: python34-3.4.10-4.el7.x86_64 (epel)
python(abi) = 3.4
```
I don't know if it is significant, but it seems to ask for python 3.7. (not libvirt related management server install.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637484977
in 4.14 we are still on python2 why are you expecting this to be tested?
@andrijapanicsb @wido
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-637657109
installing this package will install python3-* (a few of these) - worth testing this thoroughly...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638334814
This requires a docs (also branch 4.14) update to add Epel as the pre-requisite on KVM hosts.
Potentially - this whole work here in this PR, could be moved to the docs, instead of package dependency - i.e. dependency will NOT work if Epel is not installed... and making epel-release a dependency is too "bold" on the user...
Opinions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on pull request #4124: Missing python3 libvirt bindings
Posted by GitBox <gi...@apache.org>.
NuxRo commented on pull request #4124:
URL: https://github.com/apache/cloudstack/pull/4124#issuecomment-638342765
I don't see requiring epel as a problem, it's very widely used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org