You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2016/04/26 22:32:02 UTC
[Bug 59383] New: DataFormatter no longer caches formats
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
Bug ID: 59383
Summary: DataFormatter no longer caches formats
Product: POI
Version: unspecified
Hardware: PC
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: SL Common
Assignee: dev@poi.apache.org
Reporter: fxfixer@fx-soft.com
When bug 58532 was completed the line of code that adds formats to the cache
was removed. I noticed this has caused Tika to take twice as long when
processing some excel files with lots of dates/numbers.
https://github.com/apache/poi/commit/e966499ad270cb4be32faf44df304bef212df632#diff-485693a9e07b752e358b6ea116d26e02L313
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] Performance regression: DataFormatter no longer caches
formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
--- Comment #2 from Nick C <fx...@fx-soft.com> ---
I patched my local copy and one excel file with over 400K rows with dates and
numbers went from taking 1.5 minutes to 30ish seconds. Sadly when you have lots
of large excel files it adds up.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] Performance regression: DataFormatter no longer caches
formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
--- Comment #6 from Kai G <no...@kaigrabfelder.de> ---
Was a released poi version affected by this? Or was it only the current trunk?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] Performance regression: DataFormatter no longer caches
formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
--- Comment #7 from Javen O'Neal <on...@apache.org> ---
The regression was introduced on 2015-10-25, so POI 3.14-beta1 through
3.15-beta1 were affected. Search for bug 58532 on
https://poi.apache.org/changes.html
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] Performance regression: DataFormatter no longer caches
formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
Javen O'Neal <on...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |regression
Component|SL Common |SS Common
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] Performance regression: DataFormatter no longer caches
formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
Javen O'Neal <on...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|DataFormatter no longer |Performance regression:
|caches formats |DataFormatter no longer
| |caches formats
Status|NEW |NEEDINFO
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] Performance regression: DataFormatter no longer caches
formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
--- Comment #3 from Javen O'Neal <on...@apache.org> ---
Could you attach your patch?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] DataFormatter no longer caches formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
--- Comment #1 from Javen O'Neal <on...@apache.org> ---
getFormat caches data format in r1741114.
Skimming the code, createFormat does not cache data format. Would caching the
format returned by createFormat improve the speed over previous builds? If not,
should createFormat be static?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] Performance regression: DataFormatter no longer caches
formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
Javen O'Neal <on...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEEDINFO |RESOLVED
--- Comment #5 from Javen O'Neal <on...@apache.org> ---
Resolved per comment 1.
Updated changelog in r1742764.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 59383] Performance regression: DataFormatter no longer caches
formats
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59383
--- Comment #4 from Nick C <fx...@fx-soft.com> ---
The patch I had was the same as what you applied in r1741114. Thanks for making
the fix so quickly.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org