You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/25 09:49:59 UTC
[GitHub] [rocketmq] lizhanhui opened a new pull request, #4891: [ISSUE 4890] BugFix: fix binary search consume offset by time
lizhanhui opened a new pull request, #4891:
URL: https://github.com/apache/rocketmq/pull/4891
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Fix https://github.com/apache/rocketmq/issues/4890
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 4890] WIP Fix binary search consume offset by time [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4891:
URL: https://github.com/apache/rocketmq/pull/4891#issuecomment-1972184781
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyifang commented on pull request #4891: [ISSUE 4890] WIP Fix binary search consume offset by time
Posted by GitBox <gi...@apache.org>.
xiaoyifang commented on PR #4891:
URL: https://github.com/apache/rocketmq/pull/4891#issuecomment-1304369088
I think the fix is a little complex ,for a lower boundary ,we have just to search for the value `timestamp-0.5`
while `timestamp+0.5` for the upperboudary.
`timestamp+(-)0.5` must be a value between real message's timestamp and will not match any message's timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 4890] WIP Fix binary search consume offset by time [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4891: [ISSUE 4890] WIP Fix binary search consume offset by time
URL: https://github.com/apache/rocketmq/pull/4891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #4891: [ISSUE 4890] WIP Fix binary search consume offset by time
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #4891:
URL: https://github.com/apache/rocketmq/pull/4891#issuecomment-1444966026
Hi @lizhanhui is there any new progress in this PR? I think it is necessary, especially I want to improve the accuracy of the semantics of lite pull consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4891: [ISSUE 4890] WIP Fix binary search consume offset by time
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4891:
URL: https://github.com/apache/rocketmq/pull/4891#issuecomment-1233635461
I do not have the working bandwidth for this pull request, for now, let's postpone it to the next release cycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE 4890] WIP Fix binary search consume offset by time [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4891:
URL: https://github.com/apache/rocketmq/pull/4891#issuecomment-1963113092
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org