You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/21 04:32:55 UTC

[GitHub] piiswrong commented on a change in pull request #7942: Adam optimizer consistent with paper

piiswrong commented on a change in pull request #7942: Adam optimizer consistent with paper
URL: https://github.com/apache/incubator-mxnet/pull/7942#discussion_r140146798
 
 

 ##########
 File path: src/operator/optimizer_op-inl.h
 ##########
 @@ -632,6 +632,7 @@ struct AdamParam : public dmlc::Parameter<AdamParam> {
   float beta1;
   float beta2;
   float epsilon;
+  float rho;
 
 Review comment:
   it looks like rho doesn't need to be in backend? You can do the shinking in frontend.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services