You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/02/03 17:57:49 UTC

[GitHub] spark pull request #20498: [SPARK-22036][SQL][FOLLOWUP] Fix decimalArithmeti...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20498#discussion_r165820795
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/decimalArithmeticOperations.sql ---
    @@ -49,7 +49,7 @@ select 1e35 / 0.1;
     
     -- arithmetic operations causing a precision loss are truncated
     select 123456789123456789.1234567890 * 1.123456789123456789;
    -select 0.001 / 9876543210987654321098765432109876543.2
    +select 0.001 / 9876543210987654321098765432109876543.2;
    --- End diff --
    
    ... A good catch! We need to review the PR more carefully. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org