You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/25 19:39:30 UTC
[GitHub] [cloudstack] andrijapanicsb opened a new pull request #3917: Add
logging around arping in CsAddress.py
andrijapanicsb opened a new pull request #3917: Add logging around arping in CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917
IF the arping is really executed, then log it and also do a few "ping" to gtw and 8.8.8.8 - to verify connectivity.
For troubleshooting purposes only, no functional reasons (yet).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3917: Add logging
around arping in CsAddress.py
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3917: Add logging around arping in CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917#issuecomment-591088140
@andrijapanicsb good for documentation and discussion for for good order 👎 !!!
this is filling the tmp dir in the vr and is not the way to log stuff in general.
you want me to review? or propose a better solution? (not voluntering yet!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] svenvogel commented on a change in pull request #3917:
Add logging around arping in CsAddress.py
Posted by GitBox <gi...@apache.org>.
svenvogel commented on a change in pull request #3917: Add logging around arping in CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917#discussion_r384094086
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
##########
@@ -627,11 +627,14 @@ def hasIP(self, ip):
return ip in self.address.values()
def arpPing(self):
- cmd = "arping -c 1 -I %s -A -U -s %s %s" % (
- self.dev, self.address['public_ip'], self.address['gateway'])
+ #bit of logging added inside the command itself, to make sure whether it's executed or not (due to possible race/timeout conditions
+ cmd = "arping -c 1 -I %s -A -U -s %s %s >> /tmp/arpping.log" % (self.dev, self.address['public_ip'], self.address['gateway'])
if not self.cl.is_redundant() and (not self.address['gateway'] or self.address['gateway'] == "None"):
- cmd = "arping -c 1 -I %s -A -U %s" % (self.dev, self.address['public_ip'])
+ cmd = "arping -c 1 -I %s -A -U %s >> /tmp/arpping1.log" % (self.dev, self.address['public_ip'])
Review comment:
@andrijapanicsb maybe the intent is too far? maybe i am wrong... :hushed:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3917: Add logging
around arping in CsAddress.py
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3917: Add logging around arping in CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917#issuecomment-591093456
Not really atm, this is Draft PR on purpose, not to be merged (at all, for now...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request
#3917: Add logging around arping in CsAddress.py
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on a change in pull request #3917: Add logging around arping in CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917#discussion_r384104772
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
##########
@@ -627,11 +627,14 @@ def hasIP(self, ip):
return ip in self.address.values()
def arpPing(self):
- cmd = "arping -c 1 -I %s -A -U -s %s %s" % (
- self.dev, self.address['public_ip'], self.address['gateway'])
+ #bit of logging added inside the command itself, to make sure whether it's executed or not (due to possible race/timeout conditions
+ cmd = "arping -c 1 -I %s -A -U -s %s %s >> /tmp/arpping.log" % (self.dev, self.address['public_ip'], self.address['gateway'])
if not self.cl.is_redundant() and (not self.address['gateway'] or self.address['gateway'] == "None"):
- cmd = "arping -c 1 -I %s -A -U %s" % (self.dev, self.address['public_ip'])
+ cmd = "arping -c 1 -I %s -A -U %s >> /tmp/arpping1.log" % (self.dev, self.address['public_ip'])
Review comment:
@svenvogel this is just a Draft PR, won't get merged most probably - and I don't get your question?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3917: Add logging around
arping in CsAddress.py
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3917: Add logging around arping in CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917#issuecomment-592413048
-1 fix messages @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb closed pull request #3917: Add logging
around arping in CsAddress.py
Posted by GitBox <gi...@apache.org>.
andrijapanicsb closed pull request #3917: Add logging around arping in CsAddress.py
URL: https://github.com/apache/cloudstack/pull/3917
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services