You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/22 19:36:11 UTC
[GitHub] [pulsar] antimpatel opened a new pull request #6126: support for
termination of partitioned topic
antimpatel opened a new pull request #6126: support for termination of partitioned topic
URL: https://github.com/apache/pulsar/pull/6126
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #5905
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #5905
### Motivation
Pulsar supports terminate a non-partitioned-topic or a partition of a partitioned topic. If there has a partitioned topic with too many partitions, users need to get all partitions and terminate them one by one. We need to support terminate all partition of a partitioned topic.
### Modifications
Added API to support terminate all partitioned topic in PersistenceTopicBase. and added test case for the same.
*Describe the modifications you've done.*
### Verifying this change
added test case and verified.
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] antimpatel commented on issue #6126: support for
termination of partitioned topic
Posted by GitBox <gi...@apache.org>.
antimpatel commented on issue #6126: support for termination of partitioned topic
URL: https://github.com/apache/pulsar/pull/6126#issuecomment-577351859
@zymap Please check the PR, against the mentioned issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6126: support for termination
of partitioned topic
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6126: support for termination of partitioned topic
URL: https://github.com/apache/pulsar/pull/6126#issuecomment-577489469
Thanks @antimpatel for the help. left a comments related to the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] ptlanu22 commented on a change in pull request #6126:
support for termination of partitioned topic
Posted by GitBox <gi...@apache.org>.
ptlanu22 commented on a change in pull request #6126: support for termination of partitioned topic
URL: https://github.com/apache/pulsar/pull/6126#discussion_r370180377
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##########
@@ -200,6 +203,76 @@ public void testGetSubscriptions() {
Assert.assertEquals(responseCaptor.getValue().getStatus(), Response.Status.NO_CONTENT.getStatusCode());
}
+ @Test
+ public void testTerminatePartitionedTopic() {
+ String testLocalTopicName = "topic-not-found";
Review comment:
Simplified only for termination of topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on a change in pull request #6126:
support for termination of partitioned topic
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #6126: support for termination of partitioned topic
URL: https://github.com/apache/pulsar/pull/6126#discussion_r369918391
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##########
@@ -200,6 +203,76 @@ public void testGetSubscriptions() {
Assert.assertEquals(responseCaptor.getValue().getStatus(), Response.Status.NO_CONTENT.getStatusCode());
}
+ @Test
+ public void testTerminatePartitionedTopic() {
+ String testLocalTopicName = "topic-not-found";
Review comment:
Seems most of the test content is duplicate with above `testGetSubscriptions()`, Could we refine this test case to focus on topic Terminate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] ptlanu22 commented on a change in pull request #6126:
support for termination of partitioned topic
Posted by GitBox <gi...@apache.org>.
ptlanu22 commented on a change in pull request #6126: support for termination of partitioned topic
URL: https://github.com/apache/pulsar/pull/6126#discussion_r370180377
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##########
@@ -200,6 +203,76 @@ public void testGetSubscriptions() {
Assert.assertEquals(responseCaptor.getValue().getStatus(), Response.Status.NO_CONTENT.getStatusCode());
}
+ @Test
+ public void testTerminatePartitionedTopic() {
+ String testLocalTopicName = "topic-not-found";
Review comment:
Simplified only for termination of topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services