You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/16 10:15:51 UTC

[GitHub] [calcite] vlsi commented on a change in pull request #2611: [CALCITE-4887] UT

vlsi commented on a change in pull request #2611:
URL: https://github.com/apache/calcite/pull/2611#discussion_r770399852



##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -1086,14 +1086,14 @@ private void convertWhere(
   private void replaceSubQueries(
       final Blackboard bb,
       final SqlNode expr,
-      RelOptUtil.Logic logic) {
+      RelOptUtil.Logic logic, boolean isWhere) {

Review comment:
       Do you think it makes sense to add a small `enum` instead of `boolean` here?
   
   It would make the usages easier to understand.
   So far almost all the usages pass `isWhere=false`, so does it make sense to add an overloaded method for that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org