You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2017/06/23 22:23:13 UTC
[kudu-CR] [docs] Add an upgrade note about MM threads
Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7283
to review the following change.
Change subject: [docs] Add an upgrade note about MM threads
......................................................................
[docs] Add an upgrade note about MM threads
Some users configure MM threads to high values to work around the fact
that the MM was slow at scheduling tasks. This is now fixed in 1.4, so
this patch adds a note about this.
Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/7283/1
--
To view, visit http://gerrit.cloudera.org:8080/7283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Add an upgrade note about MM threads
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [docs] Add an upgrade note about MM threads
......................................................................
[docs] Add an upgrade note about MM threads
Some users configure MM threads to high values to work around the fact
that the MM was slow at scheduling tasks. This is now fixed in 1.4, so
this patch adds a note about this.
Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Reviewed-on: http://gerrit.cloudera.org:8080/7283
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Jean-Daniel Cryans <jd...@apache.org>
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Jean-Daniel Cryans: Verified
Adar Dembo: Looks good to me, but someone else must approve
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Add an upgrade note about MM threads
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7283
to look at the new patch set (#2).
Change subject: [docs] Add an upgrade note about MM threads
......................................................................
[docs] Add an upgrade note about MM threads
Some users configure MM threads to high values to work around the fact
that the MM was slow at scheduling tasks. This is now fixed in 1.4, so
this patch adds a note about this.
Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
---
M docs/release_notes.adoc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/7283/2
--
To view, visit http://gerrit.cloudera.org:8080/7283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] Add an upgrade note about MM threads
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] Add an upgrade note about MM threads
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7283/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 38: It's generally recommended to keep a 1 to 3 ratio
> Meaning, if I have 12 data directories, I should have 4 MM threads? If so,
Done
PS1, Line 39: , so operators
> ; operators
Done
PS1, Line 39: clsuters
> clusters
Done
--
To view, visit http://gerrit.cloudera.org:8080/7283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add an upgrade note about MM threads
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Add an upgrade note about MM threads
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [docs] Add an upgrade note about MM threads
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] Add an upgrade note about MM threads
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins since this is a docs change.
--
To view, visit http://gerrit.cloudera.org:8080/7283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [docs] Add an upgrade note about MM threads
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] Add an upgrade note about MM threads
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7283/1/docs/release_notes.adoc
File docs/release_notes.adoc:
PS1, Line 38: It's generally recommended to keep a 1 to 3 ratio
Meaning, if I have 12 data directories, I should have 4 MM threads? If so, reword:
Generally, the recommended ratio of MM threads to data directories is 1:3; operators of clusters above that ratio should be mindful of this when upgrading.
PS1, Line 39: clsuters
clusters
PS1, Line 39: , so operators
; operators
--
To view, visit http://gerrit.cloudera.org:8080/7283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add an upgrade note about MM threads
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [docs] Add an upgrade note about MM threads
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b9c36e04d24d0bc9991f19da35b29b474dd6022
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No