You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-commits@incubator.apache.org by rf...@apache.org on 2011/11/19 15:29:12 UTC

svn commit: r1203990 - /incubator/droids/branches/0.1.x/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java

Author: rfrovarp
Date: Sat Nov 19 15:29:11 2011
New Revision: 1203990

URL: http://svn.apache.org/viewvc?rev=1203990&view=rev
Log:
Fix add all in this branch as well

Modified:
    incubator/droids/branches/0.1.x/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java

Modified: incubator/droids/branches/0.1.x/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java
URL: http://svn.apache.org/viewvc/incubator/droids/branches/0.1.x/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java?rev=1203990&r1=1203989&r2=1203990&view=diff
==============================================================================
--- incubator/droids/branches/0.1.x/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java (original)
+++ incubator/droids/branches/0.1.x/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java Sat Nov 19 15:29:11 2011
@@ -59,15 +59,11 @@ public class SimpleTaskQueueWithHistory<
   @Override
   public boolean addAll(Collection<? extends T> c)
   {
-    HashSet<String> ids = new HashSet<String>();
+    boolean changed = false;
     for (T e : c) {
-      ids.add(e.getId());
-    }
-    if (previous.addAll(ids)) {
-      return super.addAll(c);
-    } else {
-      return false;
+      changed = changed || this.add(e);
     }
+    return changed;
   }
 
   public void clearHistory()