You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2024/09/06 11:45:44 UTC
[PR] [To rc/1.3.3] Load: Support remote load in import-tsfile script (#13352) [iotdb]
SteveYurongSu opened a new pull request, #13435:
URL: https://github.com/apache/iotdb/pull/13435
Co-authored-by: Steve Yurong Su <ro...@apache.org>
(cherry picked from commit https://github.com/apache/iotdb/commit/8a2aba23c0673e0560b7aff2ffc9b3ce9a73a5ff)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To rc/1.3.3] Load: Support remote load in import-tsfile script (#13352) [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13435:
URL: https://github.com/apache/iotdb/pull/13435#issuecomment-2333955923
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13435?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `370 lines` in your changes missing coverage. Please review.
> Project coverage is 41.44%. Comparing base [(`6e319b2`)](https://app.codecov.io/gh/apache/iotdb/commit/6e319b2b6a72346822ff41bc3dc9b975f97d2b3f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9bfe2af`)](https://app.codecov.io/gh/apache/iotdb/commit/9bfe2af20c67034edaa0138e02de27d15d35e2ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/13435?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/iotdb/tool/tsfile/ImportTsFileRemotely.java](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&filepath=iotdb-client%2Fcli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Ftool%2Ftsfile%2FImportTsFileRemotely.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L2NsaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvdG9vbC90c2ZpbGUvSW1wb3J0VHNGaWxlUmVtb3RlbHkuamF2YQ==) | 0.00% | [160 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/iotdb/tool/tsfile/ImportTsFileBase.java](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&filepath=iotdb-client%2Fcli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Ftool%2Ftsfile%2FImportTsFileBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L2NsaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvdG9vbC90c2ZpbGUvSW1wb3J0VHNGaWxlQmFzZS5qYXZh) | 0.00% | [121 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/iotdb/tool/tsfile/ImportTsFile.java](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&filepath=iotdb-client%2Fcli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Ftool%2Ftsfile%2FImportTsFile.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L2NsaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvdG9vbC90c2ZpbGUvSW1wb3J0VHNGaWxlLmphdmE=) | 0.00% | [40 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...apache/iotdb/tool/tsfile/ImportTsFileScanTool.java](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&filepath=iotdb-client%2Fcli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Ftool%2Ftsfile%2FImportTsFileScanTool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L2NsaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvdG9vbC90c2ZpbGUvSW1wb3J0VHNGaWxlU2NhblRvb2wuamF2YQ==) | 0.00% | [33 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/iotdb/tool/tsfile/ImportTsFileLocally.java](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&filepath=iotdb-client%2Fcli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Ftool%2Ftsfile%2FImportTsFileLocally.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L2NsaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvdG9vbC90c2ZpbGUvSW1wb3J0VHNGaWxlTG9jYWxseS5qYXZh) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## rc/1.3.3 #13435 +/- ##
==============================================
- Coverage 41.48% 41.44% -0.05%
Complexity 71 71
==============================================
Files 3440 3444 +4
Lines 219414 219632 +218
Branches 26112 26130 +18
==============================================
- Hits 91025 91023 -2
- Misses 128389 128609 +220
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13435?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To rc/1.3.3] Load: Support remote load in import-tsfile script (#13352) [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu closed pull request #13435: [To rc/1.3.3] Load: Support remote load in import-tsfile script (#13352)
URL: https://github.com/apache/iotdb/pull/13435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To rc/1.3.3] Load: Support remote load in import-tsfile script (#13352) [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13435:
URL: https://github.com/apache/iotdb/pull/13435#issuecomment-2333887137
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13435) **Quality Gate failed**
Failed conditions
 [3 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=13435&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [4.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13435&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13435)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org