You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/13 09:04:15 UTC
[GitHub] [druid] kaijianding commented on a change in pull request #10714: use actual dataInterval in cache key
kaijianding commented on a change in pull request #10714:
URL: https://github.com/apache/druid/pull/10714#discussion_r556362731
##########
File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/SinkQuerySegmentWalker.java
##########
@@ -230,10 +232,15 @@ public SinkQuerySegmentWalker(
// 1) Only use caching if data is immutable
// 2) Hydrants are not the same between replicas, make sure cache is local
if (hydrantDefinitelySwapped && cache.isLocal()) {
+ StorageAdapter storageAdapter = segmentAndCloseable.lhs.asStorageAdapter();
+ long segmentMinTime = storageAdapter.getMinTime().getMillis();
+ long segmentMaxTime = storageAdapter.getMaxTime().getMillis();
+ Interval actualDataInterval = Intervals.utc(segmentMinTime, segmentMaxTime);
Review comment:
yes, you are right, will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org