You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by stack <st...@duboce.net> on 2009/01/24 00:21:54 UTC

Re: svn commit: r737241 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/regionserver/HLog.java src/java/org/apache/hadoop/hbase/regionserver/HRegion.java src/test/org/apache/hadoop/hbase/regionserver/TestHLog.java

The below is committed without a chance of someone reviewing it.

Its also committed and the issue closed with no comment on the 
performance issue raised in HBASE-1148.

jimk@apache.org wrote:
> +      boolean sync = regionInfo.isMetaRegion() || regionInfo.isRootRegion();
> +      doWrite(logKey, logEdit, sync);

I thought isMetaRegion returned true whether .META. or -ROOT- region (so 
its javadoc says).
> +          (regionInfo.isMetaRegion() || regionInfo.isRootRegion()));
>   
Same here.

St.Ack