You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/07/26 07:01:34 UTC

Review Request 74525: RANGER-4317: Error message displayed when resource lookup fails is not formatted properly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74525/
-----------------------------------------------------------

Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4317
    https://issues.apache.org/jira/browse/RANGER-4317


Repository: ranger


Description
-------

When a resource lookup fails on the new UI due to some config issue,
the error message is not displayed properly
But on backbone JS, it is displayed properly.
The error message on react js must be formatted properly


Diffs
-----

  security-admin/src/main/webapp/react-webapp/src/styles/style.css 8b86453a4 


Diff: https://reviews.apache.org/r/74525/diff/1/


Testing
-------

1)Build and Verified Ranger Admin setup with this changes.
2)The error message are formatted and  displaying properly.


Thanks,

Brijesh Bhalala


Re: Review Request 74525: RANGER-4317: Error message displayed when resource lookup fails is not formatted properly

Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74525/#review225611
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On July 26, 2023, 7:01 a.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74525/
> -----------------------------------------------------------
> 
> (Updated July 26, 2023, 7:01 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4317
>     https://issues.apache.org/jira/browse/RANGER-4317
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> When a resource lookup fails on the new UI due to some config issue,
> the error message is not displayed properly
> But on backbone JS, it is displayed properly.
> The error message on react js must be formatted properly
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css 8b86453a4 
> 
> 
> Diff: https://reviews.apache.org/r/74525/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)The error message are formatted and  displaying properly.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>


Re: Review Request 74525: RANGER-4317: Error message displayed when resource lookup fails is not formatted properly

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74525/#review225618
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On July 26, 2023, 7:01 a.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74525/
> -----------------------------------------------------------
> 
> (Updated July 26, 2023, 7:01 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4317
>     https://issues.apache.org/jira/browse/RANGER-4317
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> When a resource lookup fails on the new UI due to some config issue,
> the error message is not displayed properly
> But on backbone JS, it is displayed properly.
> The error message on react js must be formatted properly
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css 8b86453a4 
> 
> 
> Diff: https://reviews.apache.org/r/74525/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)The error message are formatted and  displaying properly.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>