[jira] [Resolved] (ARROW-7338) [C++] Improve InMemoryDataSource to support generator instead of static list

["Ben Kietzman (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Kietzman resolved ARROW-7338.
---------------------------------
    Fix Version/s: 1.0.0
       Resolution: Fixed

Fixed in https://github.com/apache/arrow/pull/6235

> [C++] Improve InMemoryDataSource to support generator instead of static list
> ----------------------------------------------------------------------------
>
>                 Key: ARROW-7338
>                 URL: https://issues.apache.org/jira/browse/ARROW-7338
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++ - Dataset
>            Reporter: Francois Saint-Jacques
>            Assignee: Ben Kietzman
>            Priority: Major
>             Fix For: 1.0.0
>
>
> The constructor should take a generator
> {code:c++}
> // Some comments here
> class InMemoryDataSource : public DataSource {
>   public:
>     using Generator = std::function<Iterator<std::shared_ptr<RecordBatch>()>;
>     InMemoryDataSource(Generator&& generator);
>     // Convenience constructor to support a fixed list of RecordBatch
>     InMemoryDataSource(std::shared_ptr<RecordBatch>);
>     InMemoryDataSource(std::vector<std::shared_ptr<RecordBatch>>);
> private:
>   Generator generator;
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)