You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/02 17:23:12 UTC
[jira] [Commented] (TINKERPOP-1279) Add Iterable parameter
constructor to ConnectiveP subclasses
[ https://issues.apache.org/jira/browse/TINKERPOP-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266775#comment-15266775 ]
ASF GitHub Bot commented on TINKERPOP-1279:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/300
TINKERPOP-1279: Add Iterable<V> parameter constructor to ConnectiveP subclasses
https://issues.apache.org/jira/browse/TINKERPOP-1279
`ConnectiveP` and its two subclasses `OrP` and `AndP` now have `List<P<V>>`-based constructors. The varargs constructors have been deprecated and simply call `this(Arrays.asList(varargs))`. This is definitely cleaner as I was able to remove a bunch of awkward `List` to `Object[]` conversions in the `P`-scene.
Given that this entails a deprecation and updates to `upgrade.asciidoc`, this is aimed at `3.2.0`, not `3.1.3`.
`mvn clean install` passed.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1279
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit 444778b59010bbcffcd350b5e55cc6eb59599405
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-05-02T15:16:50Z
Using List instead of var args for ConnectiveP/OrP/AndP constructors. This makes things easier for providers. Deprecated the var args constructors (which currently just Arrays.asList(varargs) to the List-based constructor).
----
> Add Iterable<V> parameter constructor to ConnectiveP subclasses
> ---------------------------------------------------------------
>
> Key: TINKERPOP-1279
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1279
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.0-incubating, 3.1.1-incubating, 3.1.2-incubating
> Reporter: Jad Naous
>
> It's really hard to instantiate an array of generics and pass it to the constructor without warnings. Can you please use collections instead of arrays in parameters (or add an overloaded constructor)?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)