You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2017/04/27 01:37:30 UTC
Last call: any PRs for 7.1.0 release?
Hi all,
We are getting close to making a v7.1.0 RC. Please take a look at the branch, and let me know if there are any critical fixes that must get in.
Cheers,
-- Leif
Re: Last call: any PRs for 7.1.0 release?
Posted by Leif Hedstrom <zw...@apache.org>.
> On Apr 27, 2017, at 2:40 PM, Leif Hedstrom <zw...@apache.org> wrote:
>
>
>> On Apr 27, 2017, at 8:37 AM, Chao Xu <xu...@gmail.com> wrote:
>>
>> Hi Leif,
>>
>> I think that you forgot to revert this.
>>
>> commit 1450456d609fa37a0b831717dc826c5e759dafe9
>> Author: Leif Hedstrom <zw...@apache.org>
>> Date: Wed Apr 12 15:21:08 2017 -0700
>>
>> Revert "TS-4895: Initialize default_inactivity_timeout (CID 1021743
>> from TS-4612)"
>>
>> This reverts commit 9108bc942d1f0d141ec3de0082ac5b0f4f4fed6d.
>
>
>
> Done, thanks!
>
> I’m seeing an issue with some metrics related to the response codes in the 7.1.x branch, curious if anyone else is seeing this? This shows up as much to low numbers of 200, 304, 403 etc. result codes. Easiest to see this is to run “traffic_top” and hit the “r” key, in my case, they don’t add up in any reasonable way at all :-/.
Made some progress on this, it's H2 related. Git bisect narrowed it down.
Cheers,
-- Leif
>
> Cheers,
>
> — leif
>
> In this example, I’d expect 200 to be around 75%, and 304 to be around 15-20%, but I’m nowhere close to this. As you can see, the percentage numbers don’t add up to anywhere near 1005 either :-/.
>
> RESPONSE CODES
> 100 0.0% 400 0.0% 500 0.0%
> 101 0.0% 401 0.0% 501 0.0%
> 1xx 0.0% 402 0.0% 502 0.0%
> 200 41.7% 403 0.1% 503 0.0%
> 201 0.0% 404 0.0% 504 0.0%
> 202 0.0% 405 0.0% 505 0.0%
> 203 0.0% 406 0.0% 5xx 0.0%
> 204 0.0% 407 0.0%
> 205 0.0% 408 0.0%
> 206 4.4% 409 0.0%
> 2xx 46.1% 410 0.0%
> 300 0.0% 411 0.0%
> 301 0.0% 412 0.0%
> 302 0.0% 413 0.0%
> 303 0.0% 414 0.0%
> 304 1.3% 415 0.0%
> 305 0.0% 416 0.0%
> 307 0.0% 4xx 0.1%
> 3xx 1.3%
>
>
>
> ussjc2-edge-bx-026.t (m)ain (q)uit (h)elp (a)bsolute
Re: Last call: any PRs for 7.1.0 release?
Posted by Leif Hedstrom <zw...@apache.org>.
> On Apr 27, 2017, at 8:37 AM, Chao Xu <xu...@gmail.com> wrote:
>
> Hi Leif,
>
> I think that you forgot to revert this.
>
> commit 1450456d609fa37a0b831717dc826c5e759dafe9
> Author: Leif Hedstrom <zw...@apache.org>
> Date: Wed Apr 12 15:21:08 2017 -0700
>
> Revert "TS-4895: Initialize default_inactivity_timeout (CID 1021743
> from TS-4612)"
>
> This reverts commit 9108bc942d1f0d141ec3de0082ac5b0f4f4fed6d.
Done, thanks!
I’m seeing an issue with some metrics related to the response codes in the 7.1.x branch, curious if anyone else is seeing this? This shows up as much to low numbers of 200, 304, 403 etc. result codes. Easiest to see this is to run “traffic_top” and hit the “r” key, in my case, they don’t add up in any reasonable way at all :-/.
Cheers,
— leif
In this example, I’d expect 200 to be around 75%, and 304 to be around 15-20%, but I’m nowhere close to this. As you can see, the percentage numbers don’t add up to anywhere near 1005 either :-/.
RESPONSE CODES
100 0.0% 400 0.0% 500 0.0%
101 0.0% 401 0.0% 501 0.0%
1xx 0.0% 402 0.0% 502 0.0%
200 41.7% 403 0.1% 503 0.0%
201 0.0% 404 0.0% 504 0.0%
202 0.0% 405 0.0% 505 0.0%
203 0.0% 406 0.0% 5xx 0.0%
204 0.0% 407 0.0%
205 0.0% 408 0.0%
206 4.4% 409 0.0%
2xx 46.1% 410 0.0%
300 0.0% 411 0.0%
301 0.0% 412 0.0%
302 0.0% 413 0.0%
303 0.0% 414 0.0%
304 1.3% 415 0.0%
305 0.0% 416 0.0%
307 0.0% 4xx 0.1%
3xx 1.3%
ussjc2-edge-bx-026.t (m)ain (q)uit (h)elp (a)bsolute
Re: Last call: any PRs for 7.1.0 release?
Posted by Chao Xu <xu...@gmail.com>.
Hi Leif,
I think that you forgot to revert this.
commit 1450456d609fa37a0b831717dc826c5e759dafe9
Author: Leif Hedstrom <zw...@apache.org>
Date: Wed Apr 12 15:21:08 2017 -0700
Revert "TS-4895: Initialize default_inactivity_timeout (CID 1021743
from TS-4612)"
This reverts commit 9108bc942d1f0d141ec3de0082ac5b0f4f4fed6d.
2017-04-27 9:37 GMT+08:00 Leif Hedstrom <zw...@apache.org>:
> Hi all,
>
> We are getting close to making a v7.1.0 RC. Please take a look at the
> branch, and let me know if there are any critical fixes that must get in.
>
> Cheers,
>
> -- Leif
>
Re: Last call: any PRs for 7.1.0 release?
Posted by Chao Xu <xu...@gmail.com>.
Hi Leif,
https://github.com/apache/trafficserver/pull/1765
Hope not too late
Oknet Xu
2017-05-03 10:24 GMT+08:00 Leif Hedstrom <zw...@apache.org>:
>
> > On May 2, 2017, at 10:28 AM, Bryan Call <bc...@apache.org> wrote:
> >
> > I have one minor cherry pick that would be helpful not to maintain:
> >
> > commit 80dd6702931e175230cdb0ba118201ba3e515876
> > Author: Bryan Call <bc...@apache.org>
> > Date: Mon Jan 30 16:23:02 2017 -0800
> >
> > Configure option to disable CURL
>
>
> Done!
>
> Anything else? I will cut the PR tomorrow if I hear no more suggestions!
>
> — Leif
>
>
Re: Last call: any PRs for 7.1.0 release?
Posted by Leif Hedstrom <zw...@apache.org>.
> On May 2, 2017, at 10:28 AM, Bryan Call <bc...@apache.org> wrote:
>
> I have one minor cherry pick that would be helpful not to maintain:
>
> commit 80dd6702931e175230cdb0ba118201ba3e515876
> Author: Bryan Call <bc...@apache.org>
> Date: Mon Jan 30 16:23:02 2017 -0800
>
> Configure option to disable CURL
Done!
Anything else? I will cut the PR tomorrow if I hear no more suggestions!
— Leif
Re: Last call: any PRs for 7.1.0 release?
Posted by Bryan Call <bc...@apache.org>.
I have one minor cherry pick that would be helpful not to maintain:
commit 80dd6702931e175230cdb0ba118201ba3e515876
Author: Bryan Call <bc...@apache.org>
Date: Mon Jan 30 16:23:02 2017 -0800
Configure option to disable CURL
-Bryan
> On May 2, 2017, at 8:09 AM, Leif Hedstrom <zw...@apache.org> wrote:
>
>
>> On Apr 26, 2017, at 7:37 PM, Leif Hedstrom <zw...@apache.org> wrote:
>>
>> Hi all,
>>
>> We are getting close to making a v7.1.0 RC. Please take a look at the branch, and let me know if there are any critical fixes that must get in.
>
>
>
> Really, last call now! Anything we need cherry-picked before a v7.1.0 RC?
>
> Cheers,
>
> — leif
>
Re: Last call: any PRs for 7.1.0 release?
Posted by Leif Hedstrom <zw...@apache.org>.
> On Apr 26, 2017, at 7:37 PM, Leif Hedstrom <zw...@apache.org> wrote:
>
> Hi all,
>
> We are getting close to making a v7.1.0 RC. Please take a look at the branch, and let me know if there are any critical fixes that must get in.
Really, last call now! Anything we need cherry-picked before a v7.1.0 RC?
Cheers,
— leif