You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by alexjbush <gi...@git.apache.org> on 2018/07/24 14:52:49 UTC
[GitHub] zeppelin pull request #3094: [ZEPPELIN-3656] Fix for completion with Livy in...
GitHub user alexjbush opened a pull request:
https://github.com/apache/zeppelin/pull/3094
[ZEPPELIN-3656] Fix for completion with Livy interpreter
### What is this PR for?
Fix for NullPointerException when using code completion in the Livy Interpreter when Shared Interpreter is enabled.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3656](https://issues.apache.org/jira/browse/ZEPPELIN-3656)
### How should this be tested?
Run Livy Interpreter in an environment where Shared Interpreter is enabled and attempt to trigger code completions.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alexjbush/zeppelin ZEPPELIN-3656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3094.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3094
----
commit 32aa7c5670399325308fa31575ae95963d053372
Author: Alex Bush <al...@...>
Date: 2018-07-24T14:44:03Z
[ZEPPELIN-3656] Fix for completion with Livy interpreter
----
---
[GitHub] zeppelin pull request #3094: [ZEPPELIN-3656] Fix for completion with Livy in...
Posted by alexjbush <gi...@git.apache.org>.
GitHub user alexjbush reopened a pull request:
https://github.com/apache/zeppelin/pull/3094
[ZEPPELIN-3656] Fix for completion with Livy interpreter
### What is this PR for?
Fix for NullPointerException when using code completion in the Livy Interpreter when Shared Interpreter is enabled.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3656](https://issues.apache.org/jira/browse/ZEPPELIN-3656)
### How should this be tested?
Run Livy Interpreter in an environment where Shared Interpreter is enabled and attempt to trigger code completions.
A unit test has been added to test the completion API when using a shared interpreter. Before applying the fix this test was failing with the same NPE.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alexjbush/zeppelin ZEPPELIN-3656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3094.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3094
----
commit 32aa7c5670399325308fa31575ae95963d053372
Author: Alex Bush <al...@...>
Date: 2018-07-24T14:44:03Z
[ZEPPELIN-3656] Fix for completion with Livy interpreter
commit 71562e0f131b9d623338b242e514b051be4211ea
Author: Alex Bush <al...@...>
Date: 2018-07-24T15:31:55Z
Test IT for Changes
commit cd0c2133fe9e2d0962e5b8c1b9ed82e733a11e51
Author: Alex Bush <al...@...>
Date: 2018-07-24T15:54:38Z
Force a failing test
commit 4f4a875bf6dd513be05d86dae673c2ba93e52e8d
Author: Alex Bush <al...@...>
Date: 2018-07-24T16:08:22Z
Correct completion test
----
---
[GitHub] zeppelin pull request #3094: [ZEPPELIN-3656] Fix for completion with Livy in...
Posted by alexjbush <gi...@git.apache.org>.
GitHub user alexjbush reopened a pull request:
https://github.com/apache/zeppelin/pull/3094
[ZEPPELIN-3656] Fix for completion with Livy interpreter
### What is this PR for?
Fix for NullPointerException when using code completion in the Livy Interpreter when Shared Interpreter is enabled.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3656](https://issues.apache.org/jira/browse/ZEPPELIN-3656)
### How should this be tested?
Run Livy Interpreter in an environment where Shared Interpreter is enabled and attempt to trigger code completions.
A unit test has been added to test the completion API when using a shared interpreter. Before applying the fix this test was failing with the same NPE.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alexjbush/zeppelin ZEPPELIN-3656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3094.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3094
----
commit 32aa7c5670399325308fa31575ae95963d053372
Author: Alex Bush <al...@...>
Date: 2018-07-24T14:44:03Z
[ZEPPELIN-3656] Fix for completion with Livy interpreter
commit 71562e0f131b9d623338b242e514b051be4211ea
Author: Alex Bush <al...@...>
Date: 2018-07-24T15:31:55Z
Test IT for Changes
commit cd0c2133fe9e2d0962e5b8c1b9ed82e733a11e51
Author: Alex Bush <al...@...>
Date: 2018-07-24T15:54:38Z
Force a failing test
commit 4f4a875bf6dd513be05d86dae673c2ba93e52e8d
Author: Alex Bush <al...@...>
Date: 2018-07-24T16:08:22Z
Correct completion test
----
---
[GitHub] zeppelin pull request #3094: [ZEPPELIN-3656] Fix for completion with Livy in...
Posted by alexjbush <gi...@git.apache.org>.
GitHub user alexjbush reopened a pull request:
https://github.com/apache/zeppelin/pull/3094
[ZEPPELIN-3656] Fix for completion with Livy interpreter
### What is this PR for?
Fix for NullPointerException when using code completion in the Livy Interpreter when Shared Interpreter is enabled.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-3656](https://issues.apache.org/jira/browse/ZEPPELIN-3656)
### How should this be tested?
Run Livy Interpreter in an environment where Shared Interpreter is enabled and attempt to trigger code completions.
A unit test has been added to test the completion API when using a shared interpreter. Before applying the fix this test was failing with the same NPE.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alexjbush/zeppelin ZEPPELIN-3656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3094.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3094
----
commit 32aa7c5670399325308fa31575ae95963d053372
Author: Alex Bush <al...@...>
Date: 2018-07-24T14:44:03Z
[ZEPPELIN-3656] Fix for completion with Livy interpreter
commit 71562e0f131b9d623338b242e514b051be4211ea
Author: Alex Bush <al...@...>
Date: 2018-07-24T15:31:55Z
Test IT for Changes
commit cd0c2133fe9e2d0962e5b8c1b9ed82e733a11e51
Author: Alex Bush <al...@...>
Date: 2018-07-24T15:54:38Z
Force a failing test
commit 4f4a875bf6dd513be05d86dae673c2ba93e52e8d
Author: Alex Bush <al...@...>
Date: 2018-07-24T16:08:22Z
Correct completion test
----
---
[GitHub] zeppelin issue #3094: [ZEPPELIN-3656] Fix for completion with Livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3094
Please add unit test
---
[GitHub] zeppelin issue #3094: [ZEPPELIN-3656] Fix for completion with Livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3094
Don't worry, I will do the cherry-pick
---
[GitHub] zeppelin pull request #3094: [ZEPPELIN-3656] Fix for completion with Livy in...
Posted by alexjbush <gi...@git.apache.org>.
Github user alexjbush closed the pull request at:
https://github.com/apache/zeppelin/pull/3094
---
[GitHub] zeppelin issue #3094: [ZEPPELIN-3656] Fix for completion with Livy interpret...
Posted by alexjbush <gi...@git.apache.org>.
Github user alexjbush commented on the issue:
https://github.com/apache/zeppelin/pull/3094
@zjffdu I've added a test and it builds in Travis: [https://travis-ci.org/alexjbush/zeppelin/builds/407942421](https://travis-ci.org/alexjbush/zeppelin/builds/407942421)
Seems like it's failing to check out the code in Jenkins. Is there some reason for this?
Also, how can this be applied to master and 0.8.1? Will you do the merge to 0.8.1 after this is merged to master?
---
[GitHub] zeppelin issue #3094: [ZEPPELIN-3656] Fix for completion with Livy interpret...
Posted by alexjbush <gi...@git.apache.org>.
Github user alexjbush commented on the issue:
https://github.com/apache/zeppelin/pull/3094
@zjffdu Yes, but can this fix go into both master and branch-0.8 branches? Who will do this cherry picking for branch-0.8?
---
[GitHub] zeppelin pull request #3094: [ZEPPELIN-3656] Fix for completion with Livy in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3094
---
[GitHub] zeppelin pull request #3094: [ZEPPELIN-3656] Fix for completion with Livy in...
Posted by alexjbush <gi...@git.apache.org>.
Github user alexjbush closed the pull request at:
https://github.com/apache/zeppelin/pull/3094
---
[GitHub] zeppelin pull request #3094: [ZEPPELIN-3656] Fix for completion with Livy in...
Posted by alexjbush <gi...@git.apache.org>.
Github user alexjbush closed the pull request at:
https://github.com/apache/zeppelin/pull/3094
---
[GitHub] zeppelin issue #3094: [ZEPPELIN-3656] Fix for completion with Livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3094
@alexjbush Not sure what's wrong with jenkins. Maybe you can try it later.
Regarding 0.8.1, I plan to release it round one month later. Because there's other issues needs to be fixed.
---