You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/27 18:16:45 UTC
[GitHub] [incubator-nuttx] nimish opened a new pull request, #6532: Remove '-g' LDFLAG
nimish opened a new pull request, #6532:
URL: https://github.com/apache/incubator-nuttx/pull/6532
## Summary
`-g` is either ignored (gnu linker, lld) or throws an error (mold). Either way, it doesn't do anything and it's unclear why it's being added.
## Impact
`mold` doesn't crash instantly on linking
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6532: Remove '-g' LDFLAG
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6532:
URL: https://github.com/apache/incubator-nuttx/pull/6532#discussion_r907680342
##########
boards/renesas/m16c/skp16c26/scripts/Make.defs:
##########
@@ -50,5 +50,4 @@ CPPFLAGS = $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS)
AFLAGS = $(CFLAGS) -D__ASSEMBLY__
ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
Review Comment:
remove ifeq/endif
##########
arch/xtensa/src/lx7/Toolchain.defs:
##########
@@ -101,8 +101,7 @@ ifeq ($(CONFIG_DEBUG_LINK_MAP),y)
endif
ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
- LDFLAGS += -g
- ARCHOPTIMIZATION += -g
+ ARCHOPTIMIZATION += -g
Review Comment:
why change the indent?
##########
arch/xtensa/src/lx6/Toolchain.defs:
##########
@@ -101,8 +101,7 @@ ifeq ($(CONFIG_DEBUG_LINK_MAP),y)
endif
ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
- LDFLAGS += -g
- ARCHOPTIMIZATION += -g
+ ARCHOPTIMIZATION += -g
Review Comment:
please restore the indent in all place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] nimish commented on a diff in pull request #6532: Remove '-g' LDFLAG
Posted by GitBox <gi...@apache.org>.
nimish commented on code in PR #6532:
URL: https://github.com/apache/incubator-nuttx/pull/6532#discussion_r907687397
##########
arch/xtensa/src/lx7/Toolchain.defs:
##########
@@ -101,8 +101,7 @@ ifeq ($(CONFIG_DEBUG_LINK_MAP),y)
endif
ifeq ($(CONFIG_DEBUG_SYMBOLS),y)
- LDFLAGS += -g
- ARCHOPTIMIZATION += -g
+ ARCHOPTIMIZATION += -g
Review Comment:
hm, this was a find/replace error. fixing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #6532: Remove '-g' LDFLAG
Posted by GitBox <gi...@apache.org>.
acassis merged PR #6532:
URL: https://github.com/apache/incubator-nuttx/pull/6532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org