[GitHub] [arrow] ianmcook commented on pull request #9287: ARROW-11340: [C++] Add vcpkg.json manifest to cpp project root

[GitBox <gi...@apache.org>]

ianmcook commented on pull request #9287:
URL: https://github.com/apache/arrow/pull/9287#issuecomment-765515335


   Replies inline
   > Thanks Ian for working on this!
   > 
   > I have a couple of questions:
   > 
   > * could we define multiple manifest files for different use cases (e.g. for building wheels or having a minimal build)?
   
   Yes, definitely. Or would it be better to use this one as the master copy and apply patches to it to create the copies for other use cases?
   
   For safety, we should never name the copies `vcpkg.json` because Visual Studio automatically detects manifests with that file name.
   
   > * how can one utilize this manifest file (I assume we need to document this in the developer guide)? 
   
   I'm working on that in [ARROW-11336](https://issues.apache.org/jira/browse/ARROW-11336)
   
   
   > * why do we need to add a version string to the manifest (if it is mandatory than we need to update the version bumping scripts used during the release procedure)?
   
   It's mandatory. (The vcpkg docs say so and I confirmed by testing.)
   
   > 
   > Could you setup a github actions build to test it?
   
   Sure, I'll work on that
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org