You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/10 03:16:26 UTC

[GitHub] [flink-web] zhuyufeng0809 opened a new pull request, #549: [FLINK-20760][Project Website] Fix broken doc link

zhuyufeng0809 opened a new pull request, #549:
URL: https://github.com/apache/flink-web/pull/549

   ## What is the purpose of the change
   
   Fix broken doc link in Apache Flink Code Style and Quality Guide.
   
   The link in pic is broken. The [[usage of Java Optional](https://flink.apache.org/contributing/code-style-and-quality-java.md#java-optional)](https://flink.apache.org/contributing/code-style-and-quality-java.md#java-optional) should be linked to [[here](https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional)](https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional). ![img](https://issues.apache.org/jira/secure/attachment/13017608/13017608_image-2020-12-24-15-56-04-643.png)
   
   
   ## Brief change log
   
     - Fix broken doc link in following files:
       - *contributing/code-style-and-quality-common.md*
       - *contributing/code-style-and-quality-common.zh.md*
       - *content/contributing/code-style-and-quality-common.html*
       - *content/zh/contributing/code-style-and-quality-common.html*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests. I rebuilt the website locally using docker, the changes works
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-web] wuchong merged pull request #549: [FLINK-20760][Project Website] Fix broken doc link

Posted by GitBox <gi...@apache.org>.
wuchong merged PR #549:
URL: https://github.com/apache/flink-web/pull/549


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-web] zhuyufeng0809 commented on pull request #549: [FLINK-20760][Project Website] Fix broken doc link

Posted by GitBox <gi...@apache.org>.
zhuyufeng0809 commented on PR #549:
URL: https://github.com/apache/flink-web/pull/549#issuecomment-1151891546

   Hi @wuchong , could you help me to review this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-web] fsk119 commented on pull request #549: [FLINK-20760][Project Website] Fix broken doc link

Posted by GitBox <gi...@apache.org>.
fsk119 commented on PR #549:
URL: https://github.com/apache/flink-web/pull/549#issuecomment-1152037403

   Hi. You should open the PR in the Flink repo. I am not sure the usage of the Flink web repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org