[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17313: Update 3rdparty/mkldnn to v1.2.1

[GitBox <gi...@apache.org>]

TaoLv commented on a change in pull request #17313: Update 3rdparty/mkldnn to v1.2.1
URL: https://github.com/apache/incubator-mxnet/pull/17313#discussion_r392811971
 
 

 ##########
 File path: tests/cpp/operator/mkldnn_test.cc
 ##########
 @@ -100,7 +100,7 @@ static void VerifyDefMem(const mkldnn::memory &mem) {
 
 TEST(MKLDNN_UTIL_FUNC, MemFormat) {
   // Check whether the number of format is correct.
-  CHECK_EQ(mkldnn_format_tag_last, 131);
+  CHECK_EQ(mkldnn_format_tag_last, 152);
 
 Review comment:
   We need print this flag in cpp to get the value. This test was design to notify us if there are new formats added to dnnl so we need carefully check if these new formats break any integration code or the integration code need be improved to handle them. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services