[GitHub] [superset] hughhhh commented on a change in pull request #13182: feat: Move SQLAlchemy url reference to config

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #13182:
URL: https://github.com/apache/superset/pull/13182#discussion_r577928673



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -39,7 +40,19 @@ interface DatabaseModalProps {
   database?: DatabaseObject | null; // If included, will go into edit mode
 }
 
+// todo: define common type fully in types file
+interface RootState {
+  common: {
+    conf: {
+      SQLALCHEMY_DOCS_URL: string;
+    };
+  };
+  messageToast: Array<Object>;
+}
+
 const DEFAULT_TAB_KEY = '1';
+const DEFAULT_SQLALCHEMY_DOCS_URL =
+  'https://docs.sqlalchemy.org/en/rel_1_2/core/engines.html#';

Review comment:
       The default i'm using since the unit test aren't playing nice, i couldn't figure out how to get the `wrappingComponent must render its children!`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org