You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "martin-g (via GitHub)" <gi...@apache.org> on 2026/09/16 13:13:34 UTC
[PR] fix(docs): Fix code snippet in LogicalPlan docs [datafusion]
martin-g opened a new pull request, #25377:
URL: https://github.com/apache/datafusion/pull/25377
## Which issue does this PR close?
Closes N/A.
## Rationale for this change
See https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.LogicalPlan.html#visiting-and-rewriting-logicalplans
The comment says `// Projection(name, salary)` but the code does `project(vec![col("name")])?`. It should include the `col("salary")` too
## What changes are included in this PR?
The code snippet in the docstring is fixed to match the plan in the comments.
## What is the testing strategy for this PR?
Build the docs and verify that the code snippet matches the comments above it.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix(docs): Fix code snippet in LogicalPlan docs [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25377:
URL: https://github.com/apache/datafusion/pull/25377#issuecomment-5698497895
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25377?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.94%. Comparing base ([`606ae0f`](https://app.codecov.io/gh/apache/datafusion/commit/606ae0f697380a5bb903909f7ee3c731abbc6b79?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`44e57cf`](https://app.codecov.io/gh/apache/datafusion/commit/44e57cf5b33ce69fb29e24aa809eb1fccb8e9169?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25377 +/- ##
==========================================
- Coverage 81.94% 81.94% -0.01%
==========================================
Files 1135 1135
Lines 428278 428278
Branches 428278 428278
==========================================
- Hits 350952 350935 -17
- Misses 56369 56384 +15
- Partials 20957 20959 +2
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25377?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix(docs): Fix code snippet in LogicalPlan docs [datafusion]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #25377:
URL: https://github.com/apache/datafusion/pull/25377#issuecomment-5708712082
Thank you for the review, @nuno-faria !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix(docs): Fix code snippet in LogicalPlan docs [datafusion]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #25377:
URL: https://github.com/apache/datafusion/pull/25377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org