[jira] [Commented] (AMBARI-17151) Blueprint deployments fail when services manually removed from stack definitions

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-17151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324961#comment-15324961 ] 

Hadoop QA commented on AMBARI-17151:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12809453/AMBARI-17151.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server:

                  org.apache.ambari.server.controller.internal.ConfigGroupResourceProviderTest

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7298//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7298//console

This message is automatically generated.

> Blueprint deployments fail when services manually removed from stack definitions
> --------------------------------------------------------------------------------
>
>                 Key: AMBARI-17151
>                 URL: https://issues.apache.org/jira/browse/AMBARI-17151
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.4.0
>            Reporter: Robert Nettleton
>            Assignee: Robert Nettleton
>            Priority: Critical
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-17151.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In certain custom use cases, an Ambari user may choose to customize the Ambari stack definitions by manually removing services.  
> This can cause some failures during a Blueprint deployment, particularly in the area of "excluded" configurations.  
> When an "excluded" configuration type is found, the Blueprint processor attempts to add this configuration, and queries the Stack APIs to determine the service associated with this configuration type. 
> If this particular service has been manually deleted from the stacks, the Stack APIs will throw a runtime exception, which causes the entire Blueprint deployment to fail. 
> Example: 
> If Ambari Metrics is included in a Blueprint, the "storm-site" configuration type is considered an "excluded-configuration" by the stack definitions.  In this case, if the "STORM" service definitions have been removed, then the following exception will result when a cluster deployment based on a Blueprint is attempted:
> java.lang.IllegalArgumentException: Specified configuration type is not associated with any service: storm-site
>         at org.apache.ambari.server.controller.internal.Stack.getServiceForConfigType(Stack.java:485)
>         at org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.addExcludedConfigProperties(BlueprintConfigurationProcessor.java:2781)
>         at org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.setMissingConfigurations(BlueprintConfigurationProcessor.java:2751)
>         at org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor.doUpdateForClusterCreate(BlueprintConfigurationProcessor.java:335)
>         at org.apache.ambari.server.topology.ClusterConfigurationRequest.process(ClusterConfigurationRequest.java:153)
>         at org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:780)
>         at org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:754)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ...
> In these custom deployments, the Blueprints processor should be more lenient with respect to error handling.  
> If a matching service is not found for a given "excluded" configuration type, the Blueprint processor should log this as a WARNING, indicating that the stacks have likely been modified outside of Ambari.  
> I'm working on a fix for this, and will be submitting a patch soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)