[GitHub] [iceberg] jfz commented on pull request #2729: make iceberg sql command recognition more whitespace tolerant

[GitBox <gi...@apache.org>]

jfz commented on pull request #2729:
URL: https://github.com/apache/iceberg/pull/2729#issuecomment-867265389


   > Is there any possibility that this would remove whitespace where it is intended?
   > 
   > Such as maybe specific formatting in table properties that are used internally, or specific formatting in table comments? I'm not sure how often people are using comments with specific formatting or tags with multiple meaningful whitespaces in a row in them, but throwing that out there for discussion.
   > 
   > EDIT: I see now that you're not rewriting the query, just for the purposes of checking if it's an iceberg query.
   
   It doesn't rewrite the original query, I rephrased it from "parsing" to "recognition" to make it more clear.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org