You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by gwax <gi...@git.apache.org> on 2015/05/15 01:08:50 UTC
[GitHub] thrift pull request: THRIFT-1857 Replace implicit relative imports...
GitHub user gwax opened a pull request:
https://github.com/apache/thrift/pull/493
THRIFT-1857 Replace implicit relative imports with explicit relative imports.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CloverHealth/thrift python3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/493.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #493
----
commit edf7e3e8678d4620e1c4662b2906457a076a943d
Author: George Leslie-Waksman <ge...@cloverhealth.com>
Date: 2015-05-14T19:24:06Z
Fix relative imports to be explicit.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #493: THRIFT-1857 Replace implicit relative imports with...
Posted by gwax <gi...@git.apache.org>.
Github user gwax closed the pull request at:
https://github.com/apache/thrift/pull/493
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #493: THRIFT-1857 Replace implicit relative imports with explic...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/493
Hi, I know there's a long backlog here. We've worked it down from 120 open PRs to under 100 in the last month. Typically it has been up to the submitter to refresh the pull request if it does not pass the CI builds and once they do, it has been up to the submitter to email the dev mailing list to get the attention of a committer to finish the commit.
If you can rebase against master and reopen/push and it passes the CI build then we'll be in a much better position to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #493: THRIFT-1857 Replace implicit relative imports with explic...
Posted by gwax <gi...@git.apache.org>.
Github user gwax commented on the issue:
https://github.com/apache/thrift/pull/493
If nobody is going to look at it for 2 years...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #493: THRIFT-1857 Replace implicit relative imports with explic...
Posted by avis <gi...@git.apache.org>.
Github user avis commented on the issue:
https://github.com/apache/thrift/pull/493
Maybe I will...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---