You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2013/08/16 03:23:46 UTC
Review Request 13613: ClassCastException: org.apache.shindig.common.uri.Uri
cannot be cast to java.lang.String
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13613/
-----------------------------------------------------------
Review request for shindig.
Bugs: SHINDIG-1923
https://issues.apache.org/jira/browse/SHINDIG-1923
Repository: shindig
Description
-------
I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the MetadataResponse had changed from getIframeUrl to getIframeUrls (Map<String,String>). However when I try accessing the value in this map I am getting a ClassCastException.
When looking in the code I noticed,
https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
the MetadataResponse inner class has a method getIframeUrls() with return type Map<String,String>.
However in:
https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
the method getMetadata() shows the urls are defined as type Map<String,Uri>.
As the MetadataResponse API has been changed anyway, could it not just be changed to Map<String,Uri>? Or alternatively transform the map inside the GadgetsHandlerService?
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1513708
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1513708
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1513708
Diff: https://reviews.apache.org/r/13613/diff/
Testing
-------
Updated unit tests
Thanks,
Ryan Baxter
Re: Review Request 13613: ClassCastException:
org.apache.shindig.common.uri.Uri cannot be cast to java.lang.String
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13613/#review25236
-----------------------------------------------------------
Ship it!
Ship It!
- Henry Saputra
On Aug. 16, 2013, 1:23 a.m., Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13613/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 1:23 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1923
> https://issues.apache.org/jira/browse/SHINDIG-1923
>
>
> Repository: shindig
>
>
> Description
> -------
>
> I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the MetadataResponse had changed from getIframeUrl to getIframeUrls (Map<String,String>). However when I try accessing the value in this map I am getting a ClassCastException.
>
> When looking in the code I noticed,
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
>
> the MetadataResponse inner class has a method getIframeUrls() with return type Map<String,String>.
>
> However in:
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
>
> the method getMetadata() shows the urls are defined as type Map<String,Uri>.
>
> As the MetadataResponse API has been changed anyway, could it not just be changed to Map<String,Uri>? Or alternatively transform the map inside the GadgetsHandlerService?
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1513708
>
> Diff: https://reviews.apache.org/r/13613/diff/
>
>
> Testing
> -------
>
> Updated unit tests
>
>
> Thanks,
>
> Ryan Baxter
>
>
Re: Review Request 13613: ClassCastException:
org.apache.shindig.common.uri.Uri cannot be cast to java.lang.String
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13613/#review25246
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
<https://reviews.apache.org/r/13613/#comment49544>
Good catch. Should not need @Nullable here I suppose.
- Henry Saputra
On Aug. 16, 2013, 1:23 a.m., Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13613/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 1:23 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1923
> https://issues.apache.org/jira/browse/SHINDIG-1923
>
>
> Repository: shindig
>
>
> Description
> -------
>
> I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the MetadataResponse had changed from getIframeUrl to getIframeUrls (Map<String,String>). However when I try accessing the value in this map I am getting a ClassCastException.
>
> When looking in the code I noticed,
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
>
> the MetadataResponse inner class has a method getIframeUrls() with return type Map<String,String>.
>
> However in:
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
>
> the method getMetadata() shows the urls are defined as type Map<String,Uri>.
>
> As the MetadataResponse API has been changed anyway, could it not just be changed to Map<String,Uri>? Or alternatively transform the map inside the GadgetsHandlerService?
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1513708
>
> Diff: https://reviews.apache.org/r/13613/diff/
>
>
> Testing
> -------
>
> Updated unit tests
>
>
> Thanks,
>
> Ryan Baxter
>
>
Re: Review Request 13613: ClassCastException:
org.apache.shindig.common.uri.Uri cannot be cast to java.lang.String
Posted by Ryan Baxter <rb...@gmail.com>.
> On Aug. 16, 2013, 6:15 p.m., Stanton Sievers wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java, line 242
> > <https://reviews.apache.org/r/13613/diff/2/?file=341646#file341646line242>
> >
> > Any reason for the @Nullable annotations here? What actually happens if apply(Uri) throws a NPE?
> >
> > Were these meant to be Shindig's @Nullable and not javax.annotations'?
Eclipse magic added them when it generated the signature. I agree they are not needed.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13613/#review25239
-----------------------------------------------------------
On Aug. 19, 2013, 11:36 p.m., Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13613/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 11:36 p.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1923
> https://issues.apache.org/jira/browse/SHINDIG-1923
>
>
> Repository: shindig
>
>
> Description
> -------
>
> I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the MetadataResponse had changed from getIframeUrl to getIframeUrls (Map<String,String>). However when I try accessing the value in this map I am getting a ClassCastException.
>
> When looking in the code I noticed,
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
>
> the MetadataResponse inner class has a method getIframeUrls() with return type Map<String,String>.
>
> However in:
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
>
> the method getMetadata() shows the urls are defined as type Map<String,Uri>.
>
> As the MetadataResponse API has been changed anyway, could it not just be changed to Map<String,Uri>? Or alternatively transform the map inside the GadgetsHandlerService?
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1513708
>
> Diff: https://reviews.apache.org/r/13613/diff/
>
>
> Testing
> -------
>
> Updated unit tests
>
>
> Thanks,
>
> Ryan Baxter
>
>
Re: Review Request 13613: ClassCastException:
org.apache.shindig.common.uri.Uri cannot be cast to java.lang.String
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13613/#review25239
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
<https://reviews.apache.org/r/13613/#comment49534>
Any reason for the @Nullable annotations here? What actually happens if apply(Uri) throws a NPE?
Were these meant to be Shindig's @Nullable and not javax.annotations'?
- Stanton Sievers
On Aug. 16, 2013, 1:23 a.m., Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13613/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 1:23 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1923
> https://issues.apache.org/jira/browse/SHINDIG-1923
>
>
> Repository: shindig
>
>
> Description
> -------
>
> I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the MetadataResponse had changed from getIframeUrl to getIframeUrls (Map<String,String>). However when I try accessing the value in this map I am getting a ClassCastException.
>
> When looking in the code I noticed,
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
>
> the MetadataResponse inner class has a method getIframeUrls() with return type Map<String,String>.
>
> However in:
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
>
> the method getMetadata() shows the urls are defined as type Map<String,Uri>.
>
> As the MetadataResponse API has been changed anyway, could it not just be changed to Map<String,Uri>? Or alternatively transform the map inside the GadgetsHandlerService?
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1513708
>
> Diff: https://reviews.apache.org/r/13613/diff/
>
>
> Testing
> -------
>
> Updated unit tests
>
>
> Thanks,
>
> Ryan Baxter
>
>
Re: Review Request 13613: ClassCastException:
org.apache.shindig.common.uri.Uri cannot be cast to java.lang.String
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13613/#review25327
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On Aug. 19, 2013, 11:36 p.m., Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13613/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 11:36 p.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1923
> https://issues.apache.org/jira/browse/SHINDIG-1923
>
>
> Repository: shindig
>
>
> Description
> -------
>
> I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the MetadataResponse had changed from getIframeUrl to getIframeUrls (Map<String,String>). However when I try accessing the value in this map I am getting a ClassCastException.
>
> When looking in the code I noticed,
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
>
> the MetadataResponse inner class has a method getIframeUrls() with return type Map<String,String>.
>
> However in:
>
> https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
>
> the method getMetadata() shows the urls are defined as type Map<String,Uri>.
>
> As the MetadataResponse API has been changed anyway, could it not just be changed to Map<String,Uri>? Or alternatively transform the map inside the GadgetsHandlerService?
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1513708
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1513708
>
> Diff: https://reviews.apache.org/r/13613/diff/
>
>
> Testing
> -------
>
> Updated unit tests
>
>
> Thanks,
>
> Ryan Baxter
>
>
Re: Review Request 13613: ClassCastException:
org.apache.shindig.common.uri.Uri cannot be cast to java.lang.String
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13613/
-----------------------------------------------------------
(Updated Aug. 19, 2013, 11:36 p.m.)
Review request for shindig.
Changes
-------
Removed @Nullable annotations
Bugs: SHINDIG-1923
https://issues.apache.org/jira/browse/SHINDIG-1923
Repository: shindig
Description
-------
I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the MetadataResponse had changed from getIframeUrl to getIframeUrls (Map<String,String>). However when I try accessing the value in this map I am getting a ClassCastException.
When looking in the code I noticed,
https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
the MetadataResponse inner class has a method getIframeUrls() with return type Map<String,String>.
However in:
https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
the method getMetadata() shows the urls are defined as type Map<String,Uri>.
As the MetadataResponse API has been changed anyway, could it not just be changed to Map<String,Uri>? Or alternatively transform the map inside the GadgetsHandlerService?
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1513708
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1513708
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1513708
Diff: https://reviews.apache.org/r/13613/diff/
Testing
-------
Updated unit tests
Thanks,
Ryan Baxter