You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2026/03/20 01:25:09 UTC
(kudu) branch master updated (07148adc8 -> 3a5468b65)
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
from 07148adc8 [build] ignore local Claude configuration
new ad93bb73d [server] use the 'counter' type for the 'uptime' metric
new 3a5468b65 [client] make zlib's compress symbols local in libkudu_client
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/kudu/client/symbols.map | 1 +
src/kudu/server/server_base.cc | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
(kudu) 02/02: [client] make zlib's compress symbols local in libkudu_client
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 3a5468b651ad64ac6e09f94bae9fffde09c4211d
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Wed Mar 18 17:04:59 2026 -0700
[client] make zlib's compress symbols local in libkudu_client
Before this patch, The client_symbol-test on RHEL9.6 x86_84 was failing
because of the compress zlib's symbols not being local:
Found bad symbol 'compress'
Found bad symbol 'compress2'
Found bad symbol 'compressBound'
That's only with the very recent src from the master branch: 1.18.0,
1.18.1 and 1.18.x versions do not have such an issue. Also, this isn't
an issue at least on RHEL8.8 and Ubuntu 24.04 LTS with the same sources.
I didn't do RCA to understand what's the underlying reason, but [1]
looks like one of the usual suspects because of the changes to the
linker type in use. The other contributing factor might be the fact
that the system libz is also linked in as a dynamic library (that's been
so for quite some time, it seems). Why to link system libz when we do
have our own in 3rd-party? It's a good question: unless I'm missing
something, it should be addressed in a separate changelist. We either
need to fix linker search paths for zlib or switch to the OS-provided
zlib (perhaps, the former). This patch is to address the inconsistency
in the set of available symbols in the kudu_client library and fix
the recently discovered client_symbol-test's failure.
[1] https://github.com/apache/kudu/commit/1d789a87a
Change-Id: I78f1c38772050c6fd588141dc6aa499708b87fc5
Reviewed-on: http://gerrit.cloudera.org:8080/24116
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
src/kudu/client/symbols.map | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/kudu/client/symbols.map b/src/kudu/client/symbols.map
index d10dcbf56..bd4503668 100644
--- a/src/kudu/client/symbols.map
+++ b/src/kudu/client/symbols.map
@@ -12,6 +12,7 @@
# zlib
adler32*;
crc32*;
+ compress*;
deflate*;
get_crc_table;
inflate*;
(kudu) 01/02: [server] use the 'counter' type for the 'uptime' metric
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit ad93bb73de58b60d855812b3ba3e60e4d9834a43
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Wed Mar 18 15:44:13 2026 -0700
[server] use the 'counter' type for the 'uptime' metric
This patch changes the type of the 'counter' metric from 'gauge'
'counter': the metric's value monotonically increases by definition.
I didn't add any automated tests to cover this update, but I manually
verified that the 'uptime' metric is now listed as a metric of the
'counter' type when fetching data from master's and tserver's
"/metrics_prometheus" HTTP endpoint.
Change-Id: I00ef652ff5b38c600593b7fab7664d8e990f8669
Reviewed-on: http://gerrit.cloudera.org:8080/24115
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
src/kudu/server/server_base.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/kudu/server/server_base.cc b/src/kudu/server/server_base.cc
index dc38a030e..8b25e31f5 100644
--- a/src/kudu/server/server_base.cc
+++ b/src/kudu/server/server_base.cc
@@ -342,7 +342,8 @@ METRIC_DEFINE_gauge_int64(server, uptime,
"Server Uptime",
kudu::MetricUnit::kMicroseconds,
"Time interval since the server has started",
- kudu::MetricLevel::kInfo);
+ kudu::MetricLevel::kInfo,
+ kudu::EXPOSE_AS_COUNTER);
METRIC_DEFINE_gauge_int64(server, wal_dir_space_available_bytes,
"WAL Directory Space Free",
kudu::MetricUnit::kBytes,