You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Matthieu Brouillard (Jira)" <ji...@apache.org> on 2020/10/19 14:30:00 UTC

[jira] [Comment Edited] (MNG-6995) Support core extensions in modules of aggregator projects

    [ https://issues.apache.org/jira/browse/MNG-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216768#comment-17216768 ] 

Matthieu Brouillard edited comment on MNG-6995 at 10/19/20, 2:29 PM:
---------------------------------------------------------------------

> but also means Core Extensions resolution and instantiation cannot rely on anything in pom.xml

nothing related to this ticket requires anything in a pom file

> Core Extensions are global to the build

that's the point with this ticket and the aggregator pom.

> aggregator project can conceivably include modules with mutually exclusive extensions

But here we are not talking about "mutually exclusive" extensions, this could be left to the end user to use extensions that are not colliding to each others. We are "just" asking if core-extensions could be activated while loading/resolving the POM for the reactor.


was (Author: mcfoggy):
> but also means Core Extensions resolution and instantiation cannot rely on anything in pom.xml

nothing related to this ticket requires anything in a pom file

> Core Extensions are global to the build

that's the point with this ticket and the aggregator pom.

> aggregator project can conceivably include modules with mutually exclusive extensions

You probably meant `cannot`. 
But here we are not talking about "mutually exclusive" extensions, this could be left to the end user to use extensions that are not colliding to each others. We are "just" asking if core-extensions could be activated while loading/resolving the POM for the reactor.

> Support core extensions in modules of aggregator projects
> ---------------------------------------------------------
>
>                 Key: MNG-6995
>                 URL: https://issues.apache.org/jira/browse/MNG-6995
>             Project: Maven
>          Issue Type: New Feature
>          Components: Class Loading
>    Affects Versions: 3.6.3
>            Reporter: mike duigou
>            Priority: Major
>
> If you have defined core extensions using the MNG-5771 .mvn/extensions.xml mechanism and then include the module in an aggregator pom the extensions will currently be ignored. Only extensions defined in same directory as the aggregator pom will be used and those extensions will not be invoked for the modules, only for the aggregator itself.
> Ideally modules should build with whatever core extensions they have defined. Building a module as part of an aggregator should behave not differently than building the module standalone.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)