You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/27 02:51:24 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method

cloud-fan commented on a change in pull request #29232:
URL: https://github.com/apache/spark/pull/29232#discussion_r460620360



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -207,10 +207,19 @@ object OrcUtils extends Logging {
   }
 
   /**
-   * @return Returns the result schema string based on the canPruneCols flag.
-   *         resultSchemaString will be created using resultsSchema in case of
-   *         canPruneCols is true and for canPruneCols as false value
-   *         resultSchemaString will be created using the actual dataSchema.
+   * This method returns the result schema as string based on the canPruneCols flag.
+   * resultSchemaString will be created using pruned col in case of
+   * canPruneCols is true and for canPruneCols as false value
+   * resultSchemaString will be created using the actual dataSchema.
+   * Also as the part of this method update the MAPRED_INPUT_SCHEMA

Review comment:
       `update the MAPRED_INPUT_SCHEMA` -> `updates the MAPRED_INPUT_SCHEMA in the given 'conf'`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org