[jira] [Commented] (AIRFLOW-3541) Include --useAvroLogicalTypes setting for the Airflow operator GoogleCloudStorageToBigQueryOperator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746267#comment-16746267 ] 

ASF GitHub Bot commented on AIRFLOW-3541:
-----------------------------------------

BrechtDeVlieger commented on pull request #4553: [AIRFLOW-3541] Add Avro logical type conversion to bigquery hook
URL: https://github.com/apache/airflow/pull/4553
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Add option to allow logical type conversion when loading to BigQuery. 
   https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.load.useAvroLogicalTypes
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Very trivial change. Hard to test without integration with BigQuery.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Include --useAvroLogicalTypes setting for the Airflow operator GoogleCloudStorageToBigQueryOperator
> ---------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-3541
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3541
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: operators
>         Environment: Composer
>            Reporter: Monica Parpi
>            Priority: Major
>              Labels: pull-request-available
>
> Getting an error [1] when loading data from GCS into BigQuery using the GoogleCloudStorageToBigQueryOperator for a Avro schema containing this column:
> {
> "name": "date_requested",
> "type": "int",
> "logicalType": "date",
> }
> This column contains the number of days since the epoch as indicated here [2].
> It is possible to load this data into a DATE column by using the "--useAvroLogicalTypes" parameter when initiating a load using the CLI [3]
> It would be very useful if this setting could be enabled via the Airflow operator that performs the equivalent data load [4].
> Thank you!
> [ [1] https://issuetracker.google.com/35905894|https://issuetracker.google.com/35905894] 
> [[2] http://avro.apache.org/docs/current/spec.html#Date|http://avro.apache.org/docs/current/spec.html#Date]
> [3] [https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#configuration.load.useAvroLogicalTypes]
> [4] [https://airflow.apache.org/_modules/airflow/contrib/operators/gcs_to_bq.html#GoogleCloudStorageToBigQueryOperator]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)