You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/08/14 05:40:47 UTC

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23295


Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
2 files changed, 34 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/23295/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 7: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1722/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 29 Aug 2025 04:52:36 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 6:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1713/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 26 Aug 2025 05:23:47 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Gabriella Lotz, Ashwani Raina, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23295

to look at the new patch set (#6).

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 64 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/23295/6
-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:16:37 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23295/3/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

http://gerrit.cloudera.org:8080/#/c/23295/3/thirdparty/download-thirdparty.sh@281
PS3, Line 281: SQUEASEL_PATCHLEVEL=3
nit: Do you think patch level should be 4 now?



-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Aug 2025 06:35:42 +0000
Gerrit-HasComments: Yes

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23295/2//COMMIT_MSG
Commit Message:

PS2: 
> One missing part is checking against the set min TLS version and available 
Done


http://gerrit.cloudera.org:8080/#/c/23295/2/thirdparty/patches/squeasel-tls-openssl10x.patch
File thirdparty/patches/squeasel-tls-openssl10x.patch:

http://gerrit.cloudera.org:8080/#/c/23295/2/thirdparty/patches/squeasel-tls-openssl10x.patch@18
PS2, Line 18: defined(SSL_CTX_set_ciphersuites)
> I don't think SSL_CTX_set_ciphersuites is a macro, at least in OpenSSL 1.1.
Fixed it.



-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Aug 2025 21:35:57 +0000
Gerrit-HasComments: Yes

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1705/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 23 Aug 2025 04:34:42 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1707/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 24 Aug 2025 23:48:20 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1688/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Aug 2025 06:38:40 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23295/3/src/kudu/server/webserver_options.cc
File src/kudu/server/webserver_options.cc:

http://gerrit.cloudera.org:8080/#/c/23295/3/src/kudu/server/webserver_options.cc@179
PS3, Line 179:     LOG(ERROR) << "TLSv1.3 requested, but available OpenSSL version "
             :                   "is too old (need >= 1.1.1)";
With this, does it make sense to update the description for the webserver_tls_min_protocol flag as well to exclude TLSv1.3 from the list of acceptable settings if compiling with OpenSSL of versions earlier than 1.1.1?


http://gerrit.cloudera.org:8080/#/c/23295/3/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

http://gerrit.cloudera.org:8080/#/c/23295/3/thirdparty/download-thirdparty.sh@281
PS3, Line 281: SQUEASEL_PATCHLEVEL=3
> nit: Do you think patch level should be 4 now?
+1



-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Aug 2025 19:35:30 +0000
Gerrit-HasComments: Yes

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1701/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 22 Aug 2025 11:11:24 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Aug 2025 09:01:16 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23295/2//COMMIT_MSG
Commit Message:

PS2: 
One missing part is checking against the set min TLS version and available version.

It might be something similar to CheckMaxSupportedTlsVersion() in tls_context.cc, but applicable to the webserver's specific flag --webserver_tls_min_protocol


http://gerrit.cloudera.org:8080/#/c/23295/2/thirdparty/patches/squeasel-tls-openssl10x.patch
File thirdparty/patches/squeasel-tls-openssl10x.patch:

http://gerrit.cloudera.org:8080/#/c/23295/2/thirdparty/patches/squeasel-tls-openssl10x.patch@18
PS2, Line 18: defined(SSL_CTX_set_ciphersuites)
I don't think SSL_CTX_set_ciphersuites is a macro, at least in OpenSSL 1.1.1, so this isn't going to work.  Essentially, this always evaluates to false, even in OpenSSL 1.1.1 and newer.



-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Aug 2025 13:18:57 +0000
Gerrit-HasComments: Yes

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1701/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Aug 2025 23:11:20 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1709/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Aug 2025 11:09:11 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Gabriella Lotz, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23295

to look at the new patch set (#3).

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 61 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/23295/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Gabriella Lotz, Ashwani Raina, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23295

to look at the new patch set (#5).

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 64 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/23295/5
-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 22 Aug 2025 07:00:39 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Gabriella Lotz, Ashwani Raina, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23295

to look at the new patch set (#7).

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 65 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/23295/7
-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 18:09:23 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1699/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 Aug 2025 21:36:14 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 5:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1709/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Aug 2025 22:25:59 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Gabriella Lotz, Ashwani Raina, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23295

to look at the new patch set (#4).

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 64 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/23295/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Aug 2025 23:31:44 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 6:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1713/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 26 Aug 2025 11:42:25 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1705/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 23 Aug 2025 16:34:45 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23295/3/src/kudu/server/webserver_options.cc
File src/kudu/server/webserver_options.cc:

http://gerrit.cloudera.org:8080/#/c/23295/3/src/kudu/server/webserver_options.cc@179
PS3, Line 179: #else
             :     LOG(ERROR) << "TLSv1.3 requested, but avail
> With this, does it make sense to update the description for the webserver_t
Done


http://gerrit.cloudera.org:8080/#/c/23295/3/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

http://gerrit.cloudera.org:8080/#/c/23295/3/thirdparty/download-thirdparty.sh@281
PS3, Line 281: SQUEASEL_PATCHLEVEL=4
> +1
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Aug 2025 23:11:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 3:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1699/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Aug 2025 09:36:18 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 6:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1716/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Aug 2025 02:03:26 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 6:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1716/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Aug 2025 08:48:15 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23295

to look at the new patch set (#2).

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
2 files changed, 34 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/23295/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1688/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Aug 2025 05:40:53 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 5:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1707/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Aug 2025 10:16:49 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 7:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1722/


-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 29 Aug 2025 03:38:48 +0000
Gerrit-HasComments: No

[kudu-CR] Fix compilation if using OpenSSL < 1.1.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23295 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Reviewed-on: http://gerrit.cloudera.org:8080/23295
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 65 insertions(+), 7 deletions(-)

Approvals:
  Abhishek Chennaka: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/23295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23295
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)