You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2018/08/23 18:54:58 UTC
[royale-asjs] branch develop updated: Clean names and separate add
item from List and Table
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 79a1aa2 Clean names and separate add item from List and Table
79a1aa2 is described below
commit 79a1aa2a9ac7afdb3edc2b82435bab2be9b2bd01
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Thu Aug 23 20:54:53 2018 +0200
Clean names and separate add item from List and Table
---
.../JewelExample/src/main/royale/ListPlayGround.mxml | 4 ++--
.../JewelExample/src/main/royale/TablePlayGround.mxml | 2 +-
.../Jewel/src/main/resources/jewel-manifest.xml | 4 ++--
...tData.as => AddListItemRendererForArrayListData.as} | 18 +++++++++---------
.../AddTableItemRendererForArrayListData.as | 12 +++++-------
...ata.as => RemoveAllItemRendererForArrayListData.as} | 18 +++++++++---------
6 files changed, 28 insertions(+), 30 deletions(-)
diff --git a/examples/royale/JewelExample/src/main/royale/ListPlayGround.mxml b/examples/royale/JewelExample/src/main/royale/ListPlayGround.mxml
index ec24b0d..6b60d03 100644
--- a/examples/royale/JewelExample/src/main/royale/ListPlayGround.mxml
+++ b/examples/royale/JewelExample/src/main/royale/ListPlayGround.mxml
@@ -112,10 +112,10 @@ limitations under the License.
sourceID="listModel"
sourcePropertyName="iconListData"
destinationPropertyName="dataProvider" />
- <j:DynamicAddItemRendererForArrayListData/>
+ <j:AddListItemRendererForArrayListData/>
<j:DynamicRemoveItemRendererForArrayListData/>
<j:DynamicUpdateItemRendererForArrayListData/>
- <j:DynamicRemoveAllItemRendererForArrayListData/>
+ <j:RemoveAllItemRendererForArrayListData/>
</j:beads>
</j:List>
<j:Button text="Add item" click="addItem()"/>
diff --git a/examples/royale/JewelExample/src/main/royale/TablePlayGround.mxml b/examples/royale/JewelExample/src/main/royale/TablePlayGround.mxml
index de9c76a..6dd838a 100644
--- a/examples/royale/JewelExample/src/main/royale/TablePlayGround.mxml
+++ b/examples/royale/JewelExample/src/main/royale/TablePlayGround.mxml
@@ -188,7 +188,7 @@ limitations under the License.
<j:AddTableItemRendererForArrayListData/>
<j:DynamicRemoveItemRendererForArrayListData/>
<j:DynamicUpdateItemRendererForArrayListData/>
- <j:DynamicRemoveAllItemRendererForArrayListData/>
+ <j:RemoveAllItemRendererForArrayListData/>
</j:beads>
</j:Table>
diff --git a/frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml b/frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml
index 7820f6f..e5691b9 100644
--- a/frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml
+++ b/frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml
@@ -120,10 +120,10 @@
<component id="TableItemRendererFactoryForCollectionView" class="org.apache.royale.jewel.beads.itemRenderers.TableItemRendererFactoryForCollectionView"/>
- <component id="DynamicAddItemRendererForArrayListData" class="org.apache.royale.jewel.beads.itemRenderers.DynamicAddItemRendererForArrayListData" />
+ <component id="AddListItemRendererForArrayListData" class="org.apache.royale.jewel.beads.itemRenderers.AddListItemRendererForArrayListData" />
<component id="DynamicRemoveItemRendererForArrayListData" class="org.apache.royale.jewel.beads.itemRenderers.DynamicRemoveItemRendererForArrayListData" />
<component id="DynamicUpdateItemRendererForArrayListData" class="org.apache.royale.jewel.beads.itemRenderers.DynamicUpdateItemRendererForArrayListData" />
- <component id="DynamicRemoveAllItemRendererForArrayListData" class="org.apache.royale.jewel.beads.itemRenderers.DynamicRemoveAllItemRendererForArrayListData" />
+ <component id="RemoveAllItemRendererForArrayListData" class="org.apache.royale.jewel.beads.itemRenderers.RemoveAllItemRendererForArrayListData" />
<component id="AddTableItemRendererForArrayListData" class="org.apache.royale.jewel.beads.itemRenderers.AddTableItemRendererForArrayListData" />
<!-- <component id="JewelLabelViewBead" class="org.apache.royale.jewel.beads.views.JewelLabelViewBead"/> -->
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DynamicAddItemRendererForArrayListData.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
similarity index 94%
rename from frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DynamicAddItemRendererForArrayListData.as
rename to frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
index e311587..c4bc590 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DynamicAddItemRendererForArrayListData.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
@@ -35,15 +35,15 @@ package org.apache.royale.jewel.beads.itemRenderers
import org.apache.royale.utils.loadBeadFromValuesManager;
/**
- * Handles the adding of an itemRenderer once the corresponding datum has been added
+ * Handles the adding of an itemRenderer in a List component once the corresponding datum has been added
* from the IDataProviderModel.
*
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
- public class DynamicAddItemRendererForArrayListData implements IBead
+ public class AddListItemRendererForArrayListData implements IBead
{
/**
* Constructor
@@ -51,9 +51,9 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
- public function DynamicAddItemRendererForArrayListData()
+ public function AddListItemRendererForArrayListData()
{
}
@@ -67,7 +67,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function set strand(value:IStrand):void
{
@@ -115,7 +115,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
protected function handleItemAdded(event:CollectionEvent):void
{
@@ -145,7 +145,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function get dataProviderModel(): IDataProviderModel
{
@@ -164,7 +164,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function get itemRendererParent():IItemRendererParent
{
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddTableItemRendererForArrayListData.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddTableItemRendererForArrayListData.as
index eaee0cd..d7c29ad 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddTableItemRendererForArrayListData.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddTableItemRendererForArrayListData.as
@@ -47,7 +47,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public class AddTableItemRendererForArrayListData implements IBead
{
@@ -57,7 +57,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function AddTableItemRendererForArrayListData()
{
@@ -73,7 +73,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function set strand(value:IStrand):void
{
@@ -121,7 +121,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
protected function handleItemAdded(event:CollectionEvent):void
{
@@ -131,7 +131,6 @@ package org.apache.royale.jewel.beads.itemRenderers
var ir:ITextItemRenderer;
var index:int = event.index * model.columns.length;
- var rowIndex:int = index;
for(var j:int = 0; j < model.columns.length; j++)
{
column = model.columns[j] as TableColumn;
@@ -161,7 +160,6 @@ package org.apache.royale.jewel.beads.itemRenderers
// update the index values in the itemRenderers to correspond to their shifted positions.
var n:int = tbody.numElements;
var d:DataItemRenderer;
- index = event.index * model.columns.length;
for (var i:int = event.index; i < n; i++)
{
d = tbody.getItemRendererForIndex(i) as DataItemRenderer;
@@ -180,7 +178,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function get itemRendererParent():IItemRendererParent
{
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DynamicRemoveAllItemRendererForArrayListData.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveAllItemRendererForArrayListData.as
similarity index 91%
rename from frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DynamicRemoveAllItemRendererForArrayListData.as
rename to frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveAllItemRendererForArrayListData.as
index 409ddf0..1707f4b 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/DynamicRemoveAllItemRendererForArrayListData.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveAllItemRendererForArrayListData.as
@@ -30,14 +30,14 @@ package org.apache.royale.jewel.beads.itemRenderers
/**
* Handles the removal of all itemRenderers once the all items has been removed
- * from the IDataProviderModel.
+ * from the IDataProviderModel. This works the same for List and Table components
*
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
- public class DynamicRemoveAllItemRendererForArrayListData implements IBead
+ public class RemoveAllItemRendererForArrayListData implements IBead
{
/**
* Constructor
@@ -45,9 +45,9 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
- public function DynamicRemoveAllItemRendererForArrayListData()
+ public function RemoveAllItemRendererForArrayListData()
{
}
@@ -59,7 +59,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function set strand(value:IStrand):void
{
@@ -105,7 +105,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
protected function handleAllItemsRemoved(event:CollectionEvent):void
{
@@ -129,7 +129,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function get dataProviderModel(): IDataProviderModel
{
@@ -148,7 +148,7 @@ package org.apache.royale.jewel.beads.itemRenderers
* @langversion 3.0
* @playerversion Flash 10.2
* @playerversion AIR 2.6
- * @productversion Royale 0.9.0
+ * @productversion Royale 0.9.3
*/
public function get itemRendererParent():IItemRendererParent
{