[GitHub] [hop] scali commented on a diff in pull request #1540: HOP-3979 : Enhance Helm Chart

[GitBox <gi...@apache.org>]

scali commented on code in PR #1540:
URL: https://github.com/apache/hop/pull/1540#discussion_r901492230


##########
helm/hop-server/values.yaml:
##########
@@ -19,15 +19,30 @@
 # This is a YAML-formatted file.
 # Declare variables to be passed into your templates.
 
+## @param replicaCount number of replicas for the statefulset
 replicaCount: 1
 
+## @section Image
+## @param image.name Image name
+## @param image.pullPolicy Image pull policy
+## @param image.tag Visit: [Image tag](https://hub.docker.com/r/apache/hop/tags?page=1&ordering=last_updated)
+## @param image.env Environment variables
 image:
   name: docker.io/apache/hop
   pullPolicy: IfNotPresent
-  # Overrides the image tag whose default is the chart appVersion.
-  tag: "1.0-SNAPSHOT"
+  # Overrides the image tag
+  tag: "1.2.0"

Review Comment:
   It was an attempt to allow helm users to add the chart directly with `helm repo add [...]` without having to clone the whole repository, but it is finally not necessay, so you can delete it securely.
   
   For the tag, we can indeed replace `1.2.0` by `latest`, as the helm user will still have the power to choose its release in its own values file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org