You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/02/29 20:16:12 UTC
Review Request 44178: Cluster Stack Version returning wrong state
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44178/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARi-15231
https://issues.apache.org/jira/browse/AMBARi-15231
Repository: ambari
Description
-------
The computation for INSTALLED + NOT_REQUIRED should return INSTALLED. This should happen before INSTALLED + INSTALLING + NOT_REQUIRED as that results in INSTALLING.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9560a65
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql bb47a8a
ambari-server/src/main/resources/version_definition.xsd de0efd8
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java a89eb1b
Diff: https://reviews.apache.org/r/44178/diff/
Testing
-------
Manual. Automated Pending.
Thanks,
Nate Cole
Re: Review Request 44178: Cluster Stack Version returning wrong state
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44178/#review121301
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 29, 2016, 2:16 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44178/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 2:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARi-15231
> https://issues.apache.org/jira/browse/AMBARi-15231
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The computation for INSTALLED + NOT_REQUIRED should return INSTALLED. This should happen before INSTALLED + INSTALLING + NOT_REQUIRED as that results in INSTALLING.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9560a65
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql bb47a8a
> ambari-server/src/main/resources/version_definition.xsd de0efd8
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java a89eb1b
>
> Diff: https://reviews.apache.org/r/44178/diff/
>
>
> Testing
> -------
>
> Manual. Automated Pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 44178: Cluster Stack Version returning wrong state
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 29, 2016, 2:17 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/version_definition.xsd, line 57
> > <https://reviews.apache.org/r/44178/diff/1/?file=1274372#file1274372line57>
> >
> > Was amazon2015 intentional?
It was - at first it was added as a first-class OS, but then it was backtracked to be part of the redhat6 family since it looked strange on the UI. I just didn't keep up with that change quickly enough.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44178/#review121296
-----------------------------------------------------------
On Feb. 29, 2016, 2:16 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44178/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 2:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARi-15231
> https://issues.apache.org/jira/browse/AMBARi-15231
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The computation for INSTALLED + NOT_REQUIRED should return INSTALLED. This should happen before INSTALLED + INSTALLING + NOT_REQUIRED as that results in INSTALLING.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9560a65
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql bb47a8a
> ambari-server/src/main/resources/version_definition.xsd de0efd8
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java a89eb1b
>
> Diff: https://reviews.apache.org/r/44178/diff/
>
>
> Testing
> -------
>
> Manual. Automated Pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 44178: Cluster Stack Version returning wrong state
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44178/#review121296
-----------------------------------------------------------
ambari-server/src/main/resources/version_definition.xsd
<https://reviews.apache.org/r/44178/#comment182980>
Was amazon2015 intentional?
- Alejandro Fernandez
On Feb. 29, 2016, 7:16 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44178/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 7:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARi-15231
> https://issues.apache.org/jira/browse/AMBARi-15231
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The computation for INSTALLED + NOT_REQUIRED should return INSTALLED. This should happen before INSTALLED + INSTALLING + NOT_REQUIRED as that results in INSTALLING.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9560a65
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql bb47a8a
> ambari-server/src/main/resources/version_definition.xsd de0efd8
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java a89eb1b
>
> Diff: https://reviews.apache.org/r/44178/diff/
>
>
> Testing
> -------
>
> Manual. Automated Pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 44178: Cluster Stack Version returning wrong state
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44178/#review121306
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 29, 2016, 7:16 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44178/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 7:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARi-15231
> https://issues.apache.org/jira/browse/AMBARi-15231
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The computation for INSTALLED + NOT_REQUIRED should return INSTALLED. This should happen before INSTALLED + INSTALLING + NOT_REQUIRED as that results in INSTALLING.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9560a65
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql bb47a8a
> ambari-server/src/main/resources/version_definition.xsd de0efd8
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java a89eb1b
>
> Diff: https://reviews.apache.org/r/44178/diff/
>
>
> Testing
> -------
>
> Manual. Automated Pending.
>
>
> Thanks,
>
> Nate Cole
>
>