You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Swaroop883 (via GitHub)" <gi...@apache.org> on 2026/04/20 10:30:49 UTC

[PR] GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME} [arrow]

Swaroop883 opened a new pull request, #49802:
URL: https://github.com/apache/arrow/pull/49802

   ### Rationale for this change
   
   `ARROW_DOC_DIR` was hardcoded as `"share/doc/${PROJECT_NAME}"` 
   which does not respect system-specific documentation directory 
   conventions. All other install directories in this file already 
   use `GNUInstallDirs` variables (e.g. `CMAKE_INSTALL_DATADIR`, 
   `CMAKE_INSTALL_LIBDIR`). This change makes `ARROW_DOC_DIR` 
   consistent with that pattern.
   
   ### What changes are included in this PR?
   
   - Replaced `set(ARROW_DOC_DIR "share/doc/${PROJECT_NAME}")` with 
     `set(ARROW_DOC_DIR "${CMAKE_INSTALL_DOCDIR}")` in 
     `cpp/CMakeLists.txt`.
   
   ### Are these changes tested?
   
   No new tests are needed. This is a build system change that affects 
   only the install path of documentation files (LICENSE.txt, NOTICE.txt, 
   README.md). The behavior is identical on standard systems where 
   `CMAKE_INSTALL_DOCDIR` defaults to `share/doc/${PROJECT_NAME}`.
   
   ### Are there any user-facing changes?
   
   No. On standard Linux/macOS systems the install path remains 
   `share/doc/arrow`. Users who explicitly override `CMAKE_INSTALL_DOCDIR` 
   will now have their setting respected, which is the correct behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME} [arrow]

Posted by "Swaroop883 (via GitHub)" <gi...@apache.org>.
Swaroop883 commented on PR #49802:
URL: https://github.com/apache/arrow/pull/49802#issuecomment-4280214009

   Closing this as the fix has already been merged in #49790. 
   Thanks for the quick response!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME} [arrow]

Posted by "Swaroop883 (via GitHub)" <gi...@apache.org>.
Swaroop883 closed pull request #49802: GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}
URL: https://github.com/apache/arrow/pull/49802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org