You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/03 01:09:24 UTC

[PR] fix(i18n): localize instance add modal cloud form [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3021:
URL: https://github.com/apache/rocketmq-dashboard/pull/3021

   ## Summary
   
   Localize the instance add modal's cloud form (`instance/index.tsx`):
   
   - Modal title (reused dormant `instance.addInstance`), import-all tooltip + button, cancel/connect buttons (reused `instance.cancel` / `instance.connect`)
   - Cloud credential/region/cloud-instance selects: labels, required rules, placeholders (including the credential/region-first variants), the "commercial instance" extra hint, loading state, and vendor names (阿里云/腾讯云) inside the option and not-found text
   - Cloud instance ID input default-placeholder
   
   Eighteen new `instance.*` zh/en keys added (incl. `region` etc. also defined by the earlier instance-table PR with identical text).
   
   ## Why
   
   The cloud add-instance form rendered in Chinese in the English UI.
   
   ## Testing
   
   - `vitest run src/pages/instance/__tests__/InstancePage.test.tsx` → 21/21 passed
   - `tsc --noEmit` → clean
   - `eslint` on changed files → 0 errors
   - zh render unchanged
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(i18n): localize instance add modal cloud form [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3021: fix(i18n): localize instance add modal cloud form
URL: https://github.com/apache/rocketmq-dashboard/pull/3021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org