You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/05/04 11:56:00 UTC
[jira] [Commented] (LUCENE-9348) Rework grouping tests to make it
simpler to add new GroupSelector implementations
[ https://issues.apache.org/jira/browse/LUCENE-9348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098862#comment-17098862 ]
ASF subversion and git services commented on LUCENE-9348:
---------------------------------------------------------
Commit 0c58687a978ef19a4913b3a9350492d4ae6af40d in lucene-solr's branch refs/heads/master from Alan Woodward
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=0c58687 ]
LUCENE-9348: Add a base grouping test for use with different GroupSelector implementations (#1461)
The grouping module tests currently all try and test both grouping by term and
grouping by ValueSource. They are quite difficult to follow, however, and it is not
at all easy to add tests for a new grouping type. This commit adds a new
BaseGroupSelectorTestCase class which can be extended to test particular
GroupSelector implementations, and adds tests for TermGroupSelector and
ValueSourceGroupSelector. It also adds a separate test for Block grouping,
so that the distinct grouping types are tested separately.
> Rework grouping tests to make it simpler to add new GroupSelector implementations
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-9348
> URL: https://issues.apache.org/jira/browse/LUCENE-9348
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The grouping module tests currently all try and test both grouping by term and grouping by ValueSource. They are quite difficult to follow, however, and it is not at all easy to add tests for a new grouping type. We should refactor things into an abstract base class that can then be extended by tests for each specific grouping type.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org