[GitHub] [beam] riteshghorse commented on a diff in pull request #26484: [prism] Add dynamic channel & sub element splits.

["riteshghorse (via GitHub)" <gi...@apache.org>]

riteshghorse commented on code in PR #26484:
URL: https://github.com/apache/beam/pull/26484#discussion_r1182826993


##########
sdks/go/pkg/beam/runners/prism/internal/worker/bundle.go:
##########
@@ -40,47 +40,66 @@ type B struct {
 	// MultiMapSideInputData is a map from transformID, to inputID, to window, to data key, to data values.
 	MultiMapSideInputData map[string]map[string]map[typex.Window]map[string][][]byte
 
-	// OutputCount is the number of data outputs this bundle has.
+	// OutputCount is the number of data or timer outputs this bundle has.
 	// We need to see this many closed data channels before the bundle is complete.
 	OutputCount int
 	// dataWait is how we determine if a bundle is finished, by waiting for each of

Review Comment:
   ```suggestion
   	// DataWait is how we determine if a bundle is finished, by waiting for each of
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org