You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org> on 2026/10/02 12:01:57 UTC

[Impala-ASF-CR] IMPALA-15468: Calcite planner: Preserve view validation errors during alias correction

Hello Steve Carlin, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25006

to look at the new patch set (#2).

Change subject: IMPALA-15468: Calcite planner: Preserve view validation errors during alias correction
......................................................................

IMPALA-15468: Calcite planner: Preserve view validation errors during alias correction

Limit alias correction to qualified columns with AS and preserve unaffected
SELECT items, avoiding secondary ClassCastException on view validation errors.

Add regressions for SUM(BOOLEAN), TRUNC(TIMESTAMP), mixed projections and
Hive-generated aliases.

Validation: Java build and 18 related Maven tests passed.
Full upstream precommit and E2E are pending.

Change-Id: Ib51c4f3bacfdad76dc4dc4a08885b0d5e964e072
Assisted-by: GPT-6 (Codex)
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ViewAliasCorrector.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/service/ViewAliasCorrectorTest.java
2 files changed, 182 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/25006/2
-- 
To view, visit http://gerrit.cloudera.org:8080/25006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib51c4f3bacfdad76dc4dc4a08885b0d5e964e072
Gerrit-Change-Number: 25006
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>